-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable remote proxy binary downloads #6244
base: dev
Are you sure you want to change the base?
Enable remote proxy binary downloads #6244
Conversation
✅ Docs Preview ReadyNo new or changed pages found. |
CI performance tests
|
b99624c
to
58a9b65
Compare
docs/source/quickstart.mdx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR and comment in rover also applies here to naming this env var for router
docs/source/quickstart.mdx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last week we refactored the .mdx pages within router to better match the information architecture of apollographql.com/docs. That resulted in this quickstart.mdx page being removed from router, as its content is currently sourced from an internal docs repo.
We're looking into how to enable external contributions to currently internal pages. In the meantime for this PR, once we've resolved the naming for the env var and approved the content, @Meschreiber and/or I can add it to the new docs site
a488d81
to
20737df
Compare
20737df
to
064f107
Compare
whoops, rebased off the wrong thing. Lemme fix that. |
efd511e
to
b9671cc
Compare
77ccdc5
to
230e13c
Compare
6a7b233
to
ffe6f25
Compare
closing this. At the moment, without an intent to merge, I'm having to do too much work to maintain merge capability of the Pull Request. |
Description here
This enables users without direct download access to specify a remote proxy mirror location for the github download of the Apollo Router releases.
Note: I will be making a similar request for the bash binary install script for rover. Which will address apollographql/rover#1895
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
For manual testing, I set the
APOLLO_ROUTER_BINARY_REMOTE
url locally, and ran the./scripts/install.sh
script, verifying that the router was installed from github using the remote proxy instead of a direct connection.I also tested without the
APOLLO_ROUTER_BINARY_REMOTE
set, to verify current behavior of installer remains unchanged.Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩