Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable remote proxy binary downloads #6244

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

LongLiveCHIEF
Copy link

@LongLiveCHIEF LongLiveCHIEF commented Nov 7, 2024

Description here

This enables users without direct download access to specify a remote proxy mirror location for the github download of the Apollo Router releases.

Note: I will be making a similar request for the bash binary install script for rover. Which will address apollographql/rover#1895


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

For manual testing, I set the APOLLO_ROUTER_BINARY_REMOTE url locally, and ran the ./scripts/install.sh script, verifying that the router was installed from github using the remote proxy instead of a direct connection.

I also tested without the APOLLO_ROUTER_BINARY_REMOTE set, to verify current behavior of installer remains unchanged.

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@LongLiveCHIEF LongLiveCHIEF requested a review from a team as a code owner November 7, 2024 14:21
@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Nov 7, 2024

✅ Docs Preview Ready

No new or changed pages found.

@router-perf
Copy link

router-perf bot commented Nov 7, 2024

CI performance tests

  • connectors-const - Connectors stress test that runs with a constant number of users
  • const - Basic stress test that runs with a constant number of users
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • enhanced-signature - Enhanced signature enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • extended-reference-mode - Extended reference mode enabled
  • large-request - Stress test with a 1 MB request payload
  • no-tracing - Basic stress test, no tracing
  • reload - Reload test over a long period of time at a constant rate of users
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • step-local-metrics - Field stats that are generated from the router rather than FTV1
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR and comment in rover also applies here to naming this env var for router

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last week we refactored the .mdx pages within router to better match the information architecture of apollographql.com/docs. That resulted in this quickstart.mdx page being removed from router, as its content is currently sourced from an internal docs repo.

We're looking into how to enable external contributions to currently internal pages. In the meantime for this PR, once we've resolved the naming for the env var and approved the content, @Meschreiber and/or I can add it to the new docs site

@LongLiveCHIEF LongLiveCHIEF force-pushed the enable-remote-proxy-binary-downloads branch from a488d81 to 20737df Compare November 21, 2024 17:04
@LongLiveCHIEF LongLiveCHIEF force-pushed the enable-remote-proxy-binary-downloads branch from 20737df to 064f107 Compare November 21, 2024 17:04
@LongLiveCHIEF
Copy link
Author

whoops, rebased off the wrong thing. Lemme fix that.

@LongLiveCHIEF LongLiveCHIEF force-pushed the enable-remote-proxy-binary-downloads branch 2 times, most recently from efd511e to b9671cc Compare November 21, 2024 17:17
@LongLiveCHIEF LongLiveCHIEF force-pushed the enable-remote-proxy-binary-downloads branch 2 times, most recently from 77ccdc5 to 230e13c Compare December 5, 2024 14:20
@LongLiveCHIEF LongLiveCHIEF force-pushed the enable-remote-proxy-binary-downloads branch from 6a7b233 to ffe6f25 Compare December 13, 2024 17:25
@LongLiveCHIEF
Copy link
Author

closing this. At the moment, without an intent to merge, I'm having to do too much work to maintain merge capability of the Pull Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants