Remove the tracing MetricsLayer
#6566
Draft
+71
−660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes filtering functionality that is no longer used; what it does now is only rate limiting.
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 707947c756179dc5be198b8d |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟠 ❄️ Ensure queue is not active [Scheduled Freeze]Waiting for scheduled freeze to end.A freeze on the repository is scheduled for the following reason: Ensure queue is not active
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a layer for tracing-subscriber, not for tower.
MetricsLayer converts tracing events with magic prefixes to otel metrics. We no longer use this mechanism for metrics, so we can delete support for it.
Custom Rust plugins could, in the past, use the
tracingmacros to emit metrics. The migration path will be to use the opentelemetry Rust crates like we do in the router.Somewhat ready for review, but i'll keep it drafted to add a migration guide and changeset.