first pass at a functional wrapper #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smyrick
reviewed
Sep 5, 2024
smyrick
reviewed
Sep 5, 2024
smyrick
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at a functional wrapper that supports the major query/path parameters. Body support still needs finishing, but that should be simpler than this work given the foundation exists.
To help test, I do recommend using
cargo run -- config-schema > ./.vscode/configuration_schema.jsonwith the# yaml-language-server: $schema=.vscode/configuration_schema.jsonheader (just like the router) to help with the new settings.This PR primarily introduces the ability to run commands against a given endpoint according to the PQ and remap variables as needed.