Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pro 6974 update UI fields #4836

Merged
merged 18 commits into from
Jan 22, 2025
Merged
Show file tree
Hide file tree
Changes from 17 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
### Changes

* The `pickerOptions` sub property of a color field's configuration has been merged with it's parent `options` object.
* Reworks `inline` and `micro` UI of some fields (color, range, select). Improve global inline style.
* Makes the range input being a number all the time instead of a string that we convert manually.

## 4.11.2 (2024-12-29)

Expand Down
3 changes: 2 additions & 1 deletion modules/@apostrophecms/asset/lib/globalIcons.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ module.exports = {
'format-list-numbered-icon': 'FormatListNumbered',
'format-quote-close-icon': 'FormatQuoteClose',
'format-strikethrough-variant-icon': 'FormatStrikethroughVariant',
'format-superscript-icon': 'FormatSuperscript',
'format-subscript-icon': 'FormatSubscript',
'format-superscript-icon': 'FormatSuperscript',
'format-text-icon': 'FormatText',
'format-underline-icon': 'FormatUnderline',
'help-circle-icon': 'HelpCircle',
Expand Down Expand Up @@ -122,5 +122,6 @@ module.exports = {
'unfold-more-horizontal-icon': 'UnfoldMoreHorizontal',
'video-icon': 'Video',
'view-column-icon': 'ViewColumn',
'water-off-icon': 'WaterOff',
'web-icon': 'Web'
};
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,13 @@
>
<template #body>
<div class="apos-input-color">
<AposColorInfo
v-if="isInline"
class="apos-input-color__info apos-input-color__info--inline"
:value="next"
:is-micro="isMicro"
@clear="clear"
/>
<div class="apos-input-color__ui">
<AposContextMenu
:button="buttonOptions"
Expand All @@ -24,26 +31,27 @@
/>
</AposContextMenu>
</div>
<div class="apos-input-color__info" data-apos-test="colorInfo">
{{ valueLabel }}
<AposButton
v-if="next"
type="quiet"
label="apostrophe:clear"
class="apos-input-color__clear"
:modifiers="['no-motion']"
@click="clear"
/>
</div>
<AposColorInfo
v-if="!isInline"
class="apos-input-color__info"
:value="next"
:is-micro="isMicro"
@clear="clear"
/>
</div>
</template>
</AposInputWrapper>
</template>

<script>
import AposInputColorLogic from '../logic/AposInputColor';
import AposColorInfo from '../lib/AposColorInfo.vue';

export default {
name: 'AposInputColor',
components: {
AposColorInfo
},
mixins: [ AposInputColorLogic ]
};
</script>
Expand All @@ -54,16 +62,13 @@ export default {
align-items: center;
}

.apos-input-color__clear {
margin-left: 10px;
}

.apos-input-color__info {
@include type-base;
margin-left: 15px;

& {
margin-left: 15px;
color: var(--a-text-primary);
&--inline {
margin-right: 5px;
margin-left: 0;
}
}

</style>
62 changes: 62 additions & 0 deletions modules/@apostrophecms/color-field/ui/apos/lib/AposColorInfo.vue
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
<template>
<div class="apos-color-info" data-apos-test="colorInfo">
<span v-if="!isMicro">
{{ label }}
</span>
<AposButton
v-if="!isMicro && value"
type="quiet"
:label="'apostrophe:clear'"
class="apos-color-info__clear-btn"
:modifiers="['no-motion']"
@click="emit('clear')"
/>
<AposIndicator
v-else-if="value"
class="apos-color-info__clear-icon"
icon="water-off-icon"
@click="emit('clear')"
/>
</div>
</template>

<script setup>
import { computed } from 'vue';

const props = defineProps({
value: {
type: String,
default: null
},
isMicro: {
type: Boolean,
default: false
}
});

const label = computed(() => props.value || 'None Selected');
const emit = defineEmits([ 'clear' ]);
</script>

<style lang="scss">
.apos-color-info {
@include type-base;

& {
color: var(--a-text-primary);
}
}

.apos-color-info__clear-btn {
margin-left: 10px;
}

.apos-color-info__clear-icon {
cursor: pointer;
color: var(--a-base-2);

&:hover {
color: var(--a-primary);
}
}
</style>
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@ export default {
};
},
computed: {
isMicro() {
return this.modifiers.includes('micro');
},
isInline() {
return this.modifiers.includes('inline');
},
pickerValue() {
return this.next || this.defaultValue;
},
Expand All @@ -33,13 +39,6 @@ export default {
options() {
return this.field?.options || {};
},
valueLabel() {
if (this.next) {
return this.next;
} else {
return 'None Selected';
}
},
classList() {
return [
'apos-input-wrapper',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,38 @@
:uid="uid"
:display-options="displayOptions"
>
<template v-if="isMicro" #info>
<div
class="apos-range__value"
aria-hidden="true"
>
<AposIndicator
v-if="isSet"
class="apos-range__clear"
icon="close-icon"
@click="unset"
/>
<div class="apos-range__value-input">
<span v-if="isSet">
{{ valueLabel }}
</span>
</div>
</div>
</template>
<template #body>
<div class="apos-input-wrapper">
<div v-apos-tooltip="tooltip" class="apos-range">
<input
:id="uid"
v-model="next"
v-model.number="next"
type="range"
:min="field.min"
:max="field.max"
:step="field.step"
class="apos-range__input"
:disabled="field.readOnly"
>
<div class="apos-range__scale">
<div v-if="!isMicro" class="apos-range__scale">
<span>
<span class="apos-sr-only">
{{ $t('apostrophe:minLabel') }}
Expand All @@ -35,6 +53,7 @@
</div>
</div>
<div
v-if="!isMicro"
class="apos-range__value"
aria-hidden="true"
:class="{'apos-is-unset': !isSet}"
Expand Down Expand Up @@ -80,14 +99,39 @@ export default {
pointer-events: none;
}

.apos-range__clear {
margin-left: 5px;
.apos-field--micro & {
display: flex;
padding-top: 0;
min-width: auto;
}
}

.apos-range__value-input {
display: inline-flex;
box-sizing: border-box;
align-items: center;
padding: 5px 0 5px 5px;
border-radius: 5px;
min-height: 25px;
}

.apos-range__clear {
margin-left: 5px;

.apos-field--micro & {
cursor: pointer;
margin-right: 5px;
margin-left: 0;
}
}

.apos-range {
flex-grow: 1;
margin-right: 20px;

.apos-field--micro & {
margin-right: 0;
}
}

.apos-range__scale {
Expand Down Expand Up @@ -121,6 +165,10 @@ export default {
color: var(--a-text-primary);
}
}

.apos-field--micro {
margin: 0;
}
}

.apos-range__input[disabled] {
Expand Down
Loading
Loading