Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRO-2913: add writing tests for modules documentation #237

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
163 changes: 163 additions & 0 deletions docs/guide/writing-tests-for-modules.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,163 @@
# Writing tests for modules
BoDonkey marked this conversation as resolved.
Show resolved Hide resolved

BoDonkey marked this conversation as resolved.
Show resolved Hide resolved
## Requirements

- A running MongoDB server

## Setup

This setup assumes you will use the following packages

- [apostrophe](https://www.npmjs.com/package/apostrophe): *ApostropheCMS is a full-featured, open source CMS built with Node.js that seeks to empower organizations by combining in-context editing and headless architecture in a full-stack JS environment*
BoDonkey marked this conversation as resolved.
Show resolved Hide resolved
- [eslint](https://www.npmjs.com/package/eslint): *ESLint is a tool for identifying and reporting on patterns found in ECMAScript/JavaScript code*
- [eslint-config-apostrophe](https://www.npmjs.com/package/eslint-config-apostrophe): *An ESLint configuration for ApostropheCMS core and officials modules*
- [mocha](https://www.npmjs.com/package/mocha): *Simple, flexible, fun JavaScript test framework for Node.js & The Browser*
```sh
npm install --save-dev apostrophe eslint eslint-config-apostrophe mocha
BoDonkey marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting and integration testing aren't the same thing. Should we acknowledge this somewhere, maybe mention we're including linting too and what that gets us?

```

You will need to add some new scripts to your `package.json`.

```json
BoDonkey marked this conversation as resolved.
Show resolved Hide resolved
{
"scripts": {
"lint": "npm run eslint",
"eslint": "eslint .",
"test": "npm run lint && mocha"
}
}
```

When you call `npm test`, it will lint your files according to [eslint-config-apostrophe](https://www.npmjs.com/package/eslint-config-apostrophe) rules and run the tests using [mocha](https://www.npmjs.com/package/mocha).

### Test folder

You will need a `test/package.json` file referencing the repository URL of your module. Please replace `%module-name%` & `%module-repository-url%` with your module informations.

e.g. for the module [@apostrophecms/sitemap](https://github.com/apostrophecms/sitemap) we use

> `"@apostrophecms/sitemap": "git://github.com/apostrophecms/sitemap.git"`
>

```json
BoDonkey marked this conversation as resolved.
Show resolved Hide resolved
{
"/**": "This package.json file is not actually installed.",
" * ": "Apostrophe requires that all npm modules to be loaded by moog",
" */": "exist in package.json at project level, which for a test is here",
"dependencies": {
"apostrophe": "^3.26.0",
"%module-name%": "%module-repository-url%"
}
}
```

You don’t want to commit test files artifacts to git, please add the following to your `.gitignore` file

```gitignore
BoDonkey marked this conversation as resolved.
Show resolved Hide resolved
# Test files
/test/apos-build
/test/public
/test/locales
```

## Writing tests

We start with a single test file `test/index.js`.
BoDonkey marked this conversation as resolved.
Show resolved Hide resolved

As your tests grows, you can break it down into multiple files based on your liking.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"As your test grows, ..."
or
"As your tests grow, you can break them down..."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my mistake.
Grammatically the first one doesn't make exact sense. Use:
"As your tests grow, you can break them down ..."


Mocha does not play well with arrow-functions, more info at [https://mochajs.org/#arrow-functions](https://mochajs.org/#arrow-functions)


```javascript
BoDonkey marked this conversation as resolved.
Show resolved Hide resolved
// test/index.js
const assert = require('assert');
const t = require('apostrophe/test-lib/util.js');

const getAppConfig = function (options = {}) {
return {
'@apostrophecms/express': {
BoDonkey marked this conversation as resolved.
Show resolved Hide resolved
options: {
session: { secret: 'supersecret' }
BoDonkey marked this conversation as resolved.
Show resolved Hide resolved
}
},
'%module-name%': {
options: {
// pass the required options here
...options
BoDonkey marked this conversation as resolved.
Show resolved Hide resolved
}
}
};
};

describe('%module-name%', function () {
BoDonkey marked this conversation as resolved.
Show resolved Hide resolved
let apos;

this.timeout(t.timeout);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to set the environment variable to use t.timeout?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add another code comment if this is optional or not and maybe be more explicit in your 'Output' section about the steps to run the test. So do you normally use export TEST_TIMEOUT=5000, and then npm test, or feed it in directly?


after(function () {
return t.destroy(apos);
});

it('should be a property of the apos object', async function () {
BoDonkey marked this conversation as resolved.
Show resolved Hide resolved
const appConfig = getAppConfig();

await t.create({
root: module,
testModule: true,
modules: {
...appConfig,
testRunner: {
handlers(self) {
return {
'apostrophe:afterInit': {
BoDonkey marked this conversation as resolved.
Show resolved Hide resolved
checkModule () {
apos = self.apos;
assert(self.apos.modules['%module-name%']);
}
}
};
}
}
}
});
});
});
```

### Dependencies

[apostrophe/test-lib/util.js](https://github.com/apostrophecms/apostrophe/blob/main/test-lib/util.js) contains some logic to create and destroy apostrophe instances for testing purposes.

It exposes:

- `t.create` to create an apostrophe instance
- `t.destroy` to delete the database when the apostrophe instance is destroyed
- `t.createAdmin` to create an admin user
- `t.getUserJar` to get a cookie jar for the admin user
- `t.timeout` can be set using an environment variable `TEST_TIMEOUT`, e.g.`TEST_TIMEOUT=5000 npm test`

[testModule](https://github.com/apostrophecms/apostrophe/blob/main/index.js#L468) will tweak the Apostrophe environment suitably for unit tests
BoDonkey marked this conversation as resolved.
Show resolved Hide resolved

## FAQ

### MongoServerSelectionError: connect ECONNREFUSED 127.0.0.1:27017

Apostrophe assumes by default that there is MongDB server running on `127.0.0.1:27017`.

You can change it by using the environment variable `APOS_MONGODB_URI`.

```sh
APOS_MONGODB_URI=mongodb://%mongodb-address% npm test
```

### Mocha doesn't seems to work with apostrophe

Starting from Apostrophe 3.26.0, we now support Mocha 9+
([Apostrophe 3.26.0 Changelog](https://github.com/apostrophecms/apostrophe/blob/main/CHANGELOG.md#3260-2022-08-03))

If you are using an older version of Apostrophe, please use Mocha 8.

```sh
npm install --save-dev mocha@8
```