Fix aws routes per routetable and Pagination for VPCInterfaceEndpoints #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrWinston
force-pushed
the
small-fixes-to-vpc-exporter
branch
from
a22f3d4 to
f3db828
Compare
|
I opened another PR to page all calls #48 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure that collectRoutesPerRouteTableUsage actually collects the number of routes in a route table.
Also, collectInterfaceVpcEndpointsPerVpcUsage now uses pagination to get all of the endpoints, as those grow linearly with the number of private link clusters.