Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring textual representation of specs #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

m-a-r-c-e-l-i-n-o
Copy link

Hello, I don't mean to boggle anyone down with technicalities (no breakthroughs here), but I was wondering why the default textual output for the specs seem to lack a bit of consistency. If not for internal evaluation reasons, why not follow some sort of predicable format? Below are before and after images illustrating a possible improvement.

Before:
before

After:
after

For now, I've just made a few simple changes:

  1. Maybe sure that every spec had a title corresponding to their filename.
  2. Made sure that individual "it" blocks where surrounded by their respective method.
  3. Made sure that all methods/functions were prefix by a "#" as intended on some of the specs.

I feel that this is important because it shows a clear distinction of where one test starts and another ends, and what subsection it pertains to. This would allow for a quicker analysis.

Unlike the rest, the "10_temperature_object_spec.rb" spec follows a very human-linguist style, so I left it mostly alone until further discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant