Merge pull request #513 from appearhere/district-card-subtitle-optional

Make district card subtitles optional
appearhere · Feb 10, 2020 · 61bf110 · 61bf110 · vercel · Feb 10, 2020
2 parents d520c3d + 05f294d
commit 61bf110
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/packages/core/src/components/Cards/DistrictCard/DistrictCard.js b/packages/core/src/components/Cards/DistrictCard/DistrictCard.js
@@ -6,7 +6,7 @@ import Card from "../Card/Card";
 
 type Props = {
   title: string,
-  subtitle: string,
+  subtitle?: string,
   src: string,
   alt: string,
   href: string,
@@ -24,7 +24,7 @@ const DistrictCard = (props: Props) => {
 
       <div className={css.content}>
         <h3 className={css.title}>{title}</h3>
-        <p className={css.subtitle}>{subtitle}</p>
+        { subtitle && <p className={css.subtitle}>{subtitle}</p> }
       </div>
     </Card>
   );

diff --git a/packages/playground/stories/Cards.story.js b/packages/playground/stories/Cards.story.js
@@ -31,6 +31,14 @@ storiesOf('Cards', module)
       href="#"
     />
   ))
+  .add('District Card without subtitle', () => (
+    <DistrictCard
+      title="Covent Garden"
+      src="https://picsum.photos/500"
+      alt="hello"
+      href="#"
+    />
+  ))
   .add('PictureCard', () => (
     <PictureCard style={{ minHeight: '10vh' }} src="https://source.unsplash.com/random">
       Hello, world