Skip to content

Revert check for backwards time drift #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Revert check for backwards time drift #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions ...iscovery-bundle/src/main/java/io/appform/ranger/discovery/bundle/id/CollisionChecker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,7 @@ public boolean check(long curTimeMs,
dataLock.lock();
try {
long currentTime = resolution.convert(curTimeMs, TimeUnit.MILLISECONDS);
if (currentTime < lastResolvedTime) {
log.error("Clock has moved backwards. Rejecting requests until current time {} reaches {}", currentTime,
lastResolvedTime);
return false;
}
// TODO: Handle case when (currentTime < lastResolvedTime) as it can result in Duplicate IDs
if (lastResolvedTime != currentTime) {
lastResolvedTime = currentTime;
bitSet.clear();
Expand Down
9 changes: 0 additions & 9 deletions ...very-bundle/src/test/java/io/appform/ranger/discovery/bundle/id/CollisionCheckerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,4 @@ void testCheck() {
Assertions.assertFalse(collisionChecker.check(101, i));
});
}

@Test
void testCheckGoingBackInTime() {
CollisionChecker collisionChecker = new CollisionChecker();
Assertions.assertTrue(collisionChecker.check(100, 1));
Assertions.assertFalse(collisionChecker.check(90, 1));
Assertions.assertFalse(collisionChecker.check(100, 1));
Assertions.assertTrue(collisionChecker.check(101, 1));
}
}