Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add useClearTextShortcut setting #952

Merged
merged 4 commits into from
Nov 7, 2024
Merged

feat: add useClearTextShortcut setting #952

merged 4 commits into from
Nov 7, 2024

Conversation

ppken
Copy link

@ppken ppken commented Nov 6, 2024 •
edited
Loading

Addresses: appium/appium#20727

Added useClearTextShortcut setting to be able to enable / disable text clear by HIDEvent.

@ppken ppken changed the title feat: add useHIDClear capability and setting feat: add useClearTextShortcut setting Nov 6, 2024
@mykola-mokhnach
Copy link

@ppken please do not forget to document the new setting in https://github.com/appium/appium-xcuitest-driver/blob/master/docs/reference/settings.md and bump the minimum WDA version there after this change is published

@mykola-mokhnach mykola-mokhnach merged commit 61bc051 into appium:master Nov 7, 2024
39 of 43 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 7, 2024
@semantic-release-bot
chore(release): 8.10.0 [skip ci]
93f147a 
## [8.10.0](v8.9.4...v8.10.0) (2024-11-07)

### Features

* add useClearTextShortcut setting ([#952](#952)) ([61bc051](61bc051))
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

🎉 This PR is included in version 8.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ppken ppken mentioned this pull request Nov 8, 2024
Merged
@KazuCocoa KazuCocoa mentioned this pull request Nov 10, 2024
Merged
@KazuCocoa KazuCocoa added the size:S contribution size: S label Nov 10, 2024
@jlipps
Copy link
Member

jlipps commented Jan 8, 2025

Hi @ppken, congrats: the Appium project wants to compensate you for this contribution! Please reply to this comment mentioning @jlipps and @KazuCocoa and sharing your OpenCollective account name, so that we can initiate payment! Or let us know if you decline to receive compensation via OpenCollective. Thank you!

@ppken
Copy link
Author

ppken commented Jan 14, 2025

@jlipps @KazuCocoa
Thank you for your offer!

This contribution was a part of our company's work, MagicPod.
So, I decided to decline your offer for this time as an employee of MagicPod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mykola-mokhnach mykola-mokhnach mykola-mokhnach approved these changes

Assignees
No one assigned
Labels
released size:S contribution size: S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ppken @mykola-mokhnach @jlipps @KazuCocoa