Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: io.appium.settings process check with isSettingsAppServiceRunningInForeground #895

Merged
merged 7 commits into from
Jan 9, 2024

Conversation

KazuCocoa
Copy link
Member

@KazuCocoa KazuCocoa commented Jan 8, 2024

appium/appium-adb#715 is required.

@KazuCocoa
Copy link
Member Author

Plus appium/appium-adb#715

@KazuCocoa KazuCocoa changed the title fix: io.appium.settings starts every new session fix: io.appium.settings process check with hasRunningSettingsAppForegroundService Jan 8, 2024
@KazuCocoa KazuCocoa changed the title fix: io.appium.settings process check with hasRunningSettingsAppForegroundService fix: io.appium.settings process check with isSettingsAppServiceRunningInForeground Jan 9, 2024
@KazuCocoa KazuCocoa marked this pull request as ready for review January 9, 2024 19:41
@mykola-mokhnach
Copy link
Contributor

Seems like unit tests need some updates

@KazuCocoa
Copy link
Member Author

Looks good for now

@KazuCocoa KazuCocoa merged commit b9082c5 into master Jan 9, 2024
10 checks passed
@KazuCocoa KazuCocoa deleted the fix-settings-app-start branch January 9, 2024 21:57
github-actions bot pushed a commit that referenced this pull request Jan 9, 2024
## [7.6.1](v7.6.0...v7.6.1) (2024-01-09)

### Bug Fixes

* io.appium.settings process check with isSettingsAppServiceRunningInForeground ([#895](#895)) ([b9082c5](b9082c5))
Copy link

github-actions bot commented Jan 9, 2024

🎉 This PR is included in version 7.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

KazuCocoa added a commit to appium/appium-espresso-driver that referenced this pull request Jan 9, 2024
KazuCocoa added a commit to appium/appium-espresso-driver that referenced this pull request Jan 10, 2024
github-actions bot pushed a commit to appium/appium-espresso-driver that referenced this pull request Jan 10, 2024
## [2.32.2](v2.32.1...v2.32.2) (2024-01-10)

### Bug Fixes

* io.appium.settings process check as the foreground service check ([#965](#965)) ([9d4f07f](9d4f07f)), closes [appium/appium-android-driver#895](appium/appium-android-driver#895)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants