Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run lint job for all changes #1918

Merged
merged 1 commit into from
Jan 27, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .github/workflows/pr-validation-lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Code validation job, executed on pull request
# Runs linting and formatting tests

name: PR Validation

on:
pull_request:
branches: [main]

jobs:
lint:
name: Lint & Format
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
- name: Use Node.js LTS
uses: actions/setup-node@v4
with:
node-version: lts/*
cache: 'npm'
- name: Install Dependencies
run: npm ci
- name: Lint
run: npm run test:lint
- name: Format
run: npm run test:format
20 changes: 1 addition & 19 deletions .github/workflows/pr-validation.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Code validation job, executed on pull request
# Builds the app, and runs lint, unit and integration tests
# Builds the app, and runs unit and integration tests

name: PR Validation

Expand Down Expand Up @@ -37,21 +37,3 @@ jobs:
run: npm run build --if-present
- name: Test
run: npm run test:unit && npm run test:integration

lint:
name: Lint & Format
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
- name: Use Node.js LTS
uses: actions/setup-node@v4
with:
node-version: lts/*
cache: 'npm'
- name: Install Dependencies
run: npm ci
- name: Lint
run: npm run test:lint
- name: Format
run: npm run test:format
Loading