chore: bump chai and chai-as-promised (#182)

.github/workflows/unit-test.yml

@@ -5,11 +5,11 @@ jobs:
   prepare_matrix:
     runs-on: ubuntu-latest
     outputs:
-      versions: ${{ steps.generate-matrix.outputs.versions }}
+      versions: ${{ steps.generate-matrix.outputs.active }}
     steps:
-    - name: Select 3 most recent LTS versions of Node.js
+    - name: Select all active LTS versions of Node.js
       id: generate-matrix
-      run: echo "versions=$(curl -s https://endoflife.date/api/nodejs.json | jq -c '[[.[] | select(.lts != false)][:3] | .[].cycle | tonumber]')" >> "$GITHUB_OUTPUT"
+      uses: msimerson/node-lts-versions@v1
 
   test:
     runs-on: ubuntu-latest

package.json

@@ -64,16 +64,12 @@
     "@semantic-release/changelog": "^6.0.1",
     "@semantic-release/git": "^10.0.1",
     "@types/bluebird": "^3.5.38",
-    "@types/chai": "^4.3.5",
-    "@types/chai-as-promised": "^7.1.5",
     "@types/lodash": "^4.14.196",
     "@types/mocha": "^10.0.1",
     "@types/node": "^20.4.7",
-    "@types/sinon": "^17.0.0",
-    "@types/sinon-chai": "^3.2.9",
     "@types/teen_process": "^2.0.1",
-    "chai": "^4.1.2",
-    "chai-as-promised": "^7.1.1",
+    "chai": "^5.1.1",
+    "chai-as-promised": "^8.0.0",
     "conventional-changelog-conventionalcommits": "^8.0.0",
     "mocha": "^10.0.0",
     "prettier": "^3.0.0",

test/afc/afc-specs.js

@@ -1,14 +1,16 @@
-import chai from 'chai';
 import AfcService from '../../lib/afc';
 import { getServerWithFixtures, fixtures } from '../fixtures';
 
-
-chai.should();
-
 describe('afc', function () {
   let server;
   let socket;
   let service;
+  let chai;
+
+  before(async function () {
+    chai = await import('chai');
+    chai.should();
+  });
 
   afterEach(function () {
     service.close();

test/imagemounter/list-developer-image-specs.js

@@ -1,26 +1,33 @@
-import chai from 'chai';
-import chaiAsPromised from 'chai-as-promised';
 import { findDeveloperImage } from '../../lib/imagemounter/utils/list_developer_image';
 import { fs } from '@appium/support';
-chai.should();
-chai.use(chaiAsPromised);
+
+
 describe('findDeveloperImage', function () {
-    it('should download and return the correct developer image for a given version', async function () {
-        const result = await findDeveloperImage('14.7.1', {
-            githubRepo: 'appium/appium-ios-device',
-            subFolderList: ['test', 'imagemounter'],
-            branch: 'master'
-        });
-        result.developerImage.endsWith('/DeveloperDiskImage.dmg').should.be.true;
-        result.developerImageSignature.endsWith('/DeveloperDiskImage.dmg.signature').should.be.true;
-        (await fs.exists(result.developerImage)).should.be.true;
-        (await fs.exists(result.developerImageSignature)).should.be.true;
-    });
+  let chai;
 
-    it('should throw an error if the developer image cannot be found', function () {
-        findDeveloperImage('99.99.99', {
-            githubRepo: 'appium/appium-ios-device',
-            subFolderList: ['test', 'imagemounter']
-        }).should.be.rejectedWith('Failed to get developer image for iOS 99.99');
+  before(async function () {
+    chai = await import('chai');
+    const chaiAsPromised = await import('chai-as-promised');
+    chai.should();
+    chai.use(chaiAsPromised.default);
+  });
+
+  it('should download and return the correct developer image for a given version', async function () {
+    const result = await findDeveloperImage('14.7.1', {
+        githubRepo: 'appium/appium-ios-device',
+        subFolderList: ['test', 'imagemounter'],
+        branch: 'master'
     });
+    result.developerImage.endsWith('/DeveloperDiskImage.dmg').should.be.true;
+    result.developerImageSignature.endsWith('/DeveloperDiskImage.dmg.signature').should.be.true;
+    (await fs.exists(result.developerImage)).should.be.true;
+    (await fs.exists(result.developerImageSignature)).should.be.true;
+  });
+
+  it('should throw an error if the developer image cannot be found', function () {
+    findDeveloperImage('99.99.99', {
+        githubRepo: 'appium/appium-ios-device',
+        subFolderList: ['test', 'imagemounter']
+    }).should.be.rejectedWith('Failed to get developer image for iOS 99.99');
+  });
 });

test/installation-proxy/installation-proxy-service-specs.js

@@ -1,15 +1,17 @@
-import chai from 'chai';
 import InstallationServiceProxy from '../../lib/installation-proxy';
 import PlistService from '../../lib/plist-service';
 import { getServerWithFixtures, fixtures } from '../fixtures';
 
-
-chai.should();
-
 describe('installation proxy', function () {
   let server;
   let socket;
   let installationServiceProxy;
+  let chai;
+
+  before(async function () {
+    chai = await import('chai');
+    chai.should();
+  });
 
   afterEach(function () {
     if (installationServiceProxy) {

test/instrument/instrument-service-specs.js

@@ -1,16 +1,18 @@
-import chai from 'chai';
 import {InstrumentService, INSTRUMENT_CHANNEL} from '../../lib/instrument';
 import { getServerWithFixtures, fixtures } from '../fixtures';
 import B from 'bluebird';
 
-
-chai.should();
-
 describe('instrument', function () {
   let server;
   let socket;
   let instrumentService;
   const pid = 6385;
+  let chai;
+
+  before(async function () {
+    chai = await import('chai');
+    chai.should();
+  });
 
   afterEach(function () {
     if (instrumentService) {

test/instrument/nskeyed-specs.js

@@ -1,11 +1,13 @@
-import chai from 'chai';
 import {unarchive, archive, NSURL, NSUUID, NSDate} from '../../lib/instrument/transformer/nskeyed';
 import {v4} from 'uuid';
 
-
-chai.should();
-
 describe('NSKeyedArchive', function () {
+  let chai;
+
+  before(async function () {
+    chai = await import('chai');
+    chai.should();
+  });
 
   it('should parses JavaScript objects into iOS NSKeyedArchive data', function () {
     const data = {

test/lockdown/lockdown-specs.js

@@ -1,16 +1,18 @@
 import { Lockdown } from '../../lib/lockdown';
 import { PlistService } from '../../lib/plist-service';
 import { getServerWithFixtures, fixtures } from '../fixtures';
-import chai from 'chai';
-import chaiAsPromised from 'chai-as-promised';
-
-
-chai.should();
-chai.use(chaiAsPromised);
 
 describe('lockdown', function () {
   let server;
   let socket;
+  let chai;
+
+  before(async function () {
+    chai = await import('chai');
+    const chaiAsPromised = await import('chai-as-promised');
+    chai.should();
+    chai.use(chaiAsPromised.default);
+  });
 
   afterEach(function () {
     try {

test/syslog/syslog-service-specs.js

@@ -1,16 +1,18 @@
 import B from 'bluebird';
-import chai from 'chai';
 import SyslogService from '../../lib/syslog';
 import { getServerWithFixtures, fixtures } from '../fixtures';
 import { toUtf8String } from '../../lib/syslog/transformer/syslog-decoder';
 
-
-chai.should();
-
 describe('syslog', function () {
   let server;
   let socket;
   let syslogService;
+  let chai;
+
+  before(async function () {
+    chai = await import('chai');
+    chai.should();
+  });
 
   afterEach(function () {
     syslogService?.close();

test/usbmux/usbmux-specs.js

@@ -1,14 +1,16 @@
 import { Usbmux } from '../..';
-import chai from 'chai';
 import { getServerWithFixtures, fixtures, UDID } from '../fixtures';
 
-
-chai.should();
-
 describe('usbmux', function () {
   let usbmux;
   let server;
   let socket;
+  let chai;
+
+  before(async function () {
+    chai = await import('chai');
+    chai.should();
+  });
 
   afterEach(function () {
     try {

test/utilities-specs.js

@@ -1,13 +1,16 @@
 import { utilities } from '..';
-import chai from 'chai';
 import { getServerWithFixtures, fixtures, UDID } from './fixtures';
 
 
-chai.should();
-
 describe('utilities', function () {
   let server;
   let socket;
+  let chai;
+
+  before(async function () {
+    chai = await import('chai');
+    chai.should();
+  });
 
   afterEach(function () {
     if (server) {

test/webinspector/webinspector-helpers-specs.js

@@ -1,10 +1,12 @@
-import chai from 'chai';
 import { cleanupRpcObject } from '../../lib/webinspector';
 
-
-chai.should();
-
 describe('webinspector helpers', function () {
+  let chai;
+
+  before(async function () {
+    chai = await import('chai');
+    chai.should();
+  });
 
   it('should cleanup an rpc object', function () {
     cleanupRpcObject({

test/webinspector/webinspector-service-specs.js

@@ -1,16 +1,18 @@
-import chai from 'chai';
 import B from 'bluebird';
 import semver from 'semver';
 import WebInspectorService from '../../lib/webinspector';
 import { getServerWithFixtures, fixtures } from '../fixtures';
 
-
-chai.should();
-
 describe('webinspector', function () {
   let server;
   let socket;
   let webInspectorService;
+  let chai;
+
+  before(async function () {
+    chai = await import('chai');
+    chai.should();
+  });
 
   afterEach(function () {
     if (webInspectorService) {