add simulator check

appium · Aug 30, 2024 · 2185145 · 2185145
1 parent 43434dc
commit 2185145
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/lib/commands/simctl.js b/lib/commands/simctl.js
@@ -47,6 +47,10 @@ const commands = {
    * @throws {Error} If the simctl subcommand command returns non-zero return code, or the given subcommand was invalid.
    */
   async mobileSimctl(command, args = []) {
+    if (!this.isSimulator()) {
+      throw new errors.UnsupportedOperationError(`Only simulator is supported.`);
+    };
+
     if (!this.opts.udid) {
       throw new errors.InvalidArgumentError(`Unknown device or simulator UDID: '${this.opts.udid}'`);
     }

diff --git a/test/unit/commands/simctl-specs.js b/test/unit/commands/simctl-specs.js
@@ -27,6 +27,7 @@ describe('general commands', function () {
   describe('simctl', function () {
     it('should call xcrun simctl', async function () {
       driver.opts.udid = '60EB8FDB-92E0-4895-B466-0153C6DE7BAE';
+      driver.isSimulator = () => true;
       mockSimctl.expects('exec').once().withExactArgs(
         'getenv',
         {args: ['60EB8FDB-92E0-4895-B466-0153C6DE7BAE', 'HOME']}
@@ -36,6 +37,7 @@ describe('general commands', function () {
 
     it('should raise an error as not supported command', async function () {
       driver.opts.udid = '60EB8FDB-92E0-4895-B466-0153C6DE7BAE';
+      driver.isSimulator = () => true;
       mockSimctl.expects('exec').never();
       await driver.mobileSimctl(
         'list',
@@ -45,6 +47,16 @@ describe('general commands', function () {
 
     it('should raise an error as no udid', async function () {
       driver.opts.udid = null;
+      driver.isSimulator = () => true;
+      mockSimctl.expects('exec').never();
+      await driver.mobileSimctl(
+        'getenv', ['HOME']
+      ).should.eventually.be.rejected;
+    });
+
+    it('should raise an error for non-simulator', async function () {
+      driver.opts.udid = '60EB8FDB-92E0-4895-B466-0153C6DE7BAE';
+      driver.isSimulator = () => false;
       mockSimctl.expects('exec').never();
       await driver.mobileSimctl(
         'getenv', ['HOME']