chore: tvOS 17 workaround #2178
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
This was not necessary. The ip address thing was not fully paired yet, but help Xcode to detect the device |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge this yet. I'll modify the error message etc if this works for tvOS iOS 17.
This PR aims to add a workaround for appium/appium#19343
TvOS 17 changes the device paring method to use IP v6 first according to appium/appium#19343. I need more time to investigate the change, but as a workaround, we can allow a session to start by skipping device detection logic in a new session request.
On my network-connected device (iPad tho), with this change, with
webDriverAgentUrlor starting WDA fromxcodebuildsucceeded in starting a new session request and issuing commands that worked via WDA as appium XCUITest session.The given
udidwill be used for xcodebuild, so theidshould be the existing udid style (not IP address), but xcuitest driver won't verify that.