Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rewrite py-ios-device client and crash reports logger into typescript #2423

Merged
merged 11 commits into from
Jul 4, 2024

Conversation

mykola-mokhnach
Copy link
Contributor

In general pyidevice and pymobiledevice3 are quite similar, so I had an idea to create a client for the latter and combine it with pyidevice under the same BaseDeviceClient interface. This will allow to transparently switch between them if at least one is installed on the host where the driver runs. I personally would prefer pymobiledevice3 as it is maintained better and has wider functionality.

@mykola-mokhnach mykola-mokhnach requested a review from KazuCocoa July 3, 2024 21:03
lib/device-log/ios-crash-log.ts Outdated Show resolved Hide resolved
lib/commands/pcap.js Show resolved Hide resolved
Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mykola-mokhnach mykola-mokhnach merged commit 8d405e8 into appium:master Jul 4, 2024
18 checks passed
@mykola-mokhnach mykola-mokhnach deleted the mobile_dev branch July 4, 2024 09:31
github-actions bot pushed a commit that referenced this pull request Jul 4, 2024
## [7.23.0](v7.22.1...v7.23.0) (2024-07-04)

### Features

* Rewrite py-ios-device client and crash reports logger into typescript ([#2423](#2423)) ([8d405e8](8d405e8))
Copy link
Contributor

github-actions bot commented Jul 4, 2024

🎉 This issue has been resolved in version 7.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants