fix: Update hashing and iteration logic of page object items #2067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykola-mokhnach
requested review from
SrinivasanTarget,
saikrishna321 and
valfirst
as code owners
|
Android CI still needs some attention. Currently blocked by SeleniumHQ/selenium#13096 |
SrinivasanTarget
approved these changes
Nov 4, 2023
mykola-mokhnach
force-pushed
the
obj_methods
branch
from
86e2cf5 to
d173837
Compare
valfirst
reviewed
Nov 7, 2023
This reverts commit 849ba17.
valfirst
reviewed
Nov 7, 2023
| @@ -228,7 +239,6 @@ tasks.register('uiAutomationTest', Test) { | |||
| includeTestsMatching 'io.appium.java_client.android.OpenNotificationsTest' | |||
| includeTestsMatching '*.AndroidAppStringsTest' | |||
| includeTestsMatching '*.pagefactory_tests.widget.tests.android.*' | |||
| includeTestsMatching '*.pagefactory_tests.widget.tests.AndroidPageObjectTest' | |||
There was a problem hiding this comment.
is it removed intentionally?
There was a problem hiding this comment.
yes. The current pattern does not match anything. I've fixed it, but these tests still fail because of the CI slowness (I've verified them locally though). Maybe someone would find some time to make them work in the slow CI env 🤷
valfirst
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
Adresses #2066
Types of changes