Calling NPM without the user's shell profile. #2123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the NPM man page, npm gets its configuration information from 5 separate sources. When npm is launched on a *nix system without the user shell npm skips any configuration in the user's $HOME as well as ignores environment variables that might be set in the user's profile or environment. This resolves appium#1889 and @ZuhayrMerchant110's issue as well as mine where the project directory prefixing the appium path.
Greeley
requested review from
mykola-mokhnach,
SrinivasanTarget,
saikrishna321 and
valfirst
as code owners
|
| @@ -147,7 +147,8 @@ private static File findMainScript() { | |||
| List<String> cmdLine = System.getProperty("os.name").toLowerCase().contains("win") | |||
| // npm is a batch script, so on windows we need to use cmd.exe in order to execute it | |||
| ? Arrays.asList("cmd.exe", "/c", String.format("\"%s\" root -g", npm.getAbsolutePath())) | |||
| : Arrays.asList(npm.getAbsolutePath(), "root", "-g"); | |||
| //ProcessBuilder doesn't execute a shell, some npm functionality requires the user's shell profile | |||
| : Arrays.asList("/bin/sh", "--login", "-c", npm.getAbsolutePath() + " root -g"); | |||
There was a problem hiding this comment.
this would probably fail if the path to npm contains spaces.
We must properly escape it
|
@Greeley Could you please accept the CLA and update the PR title according to https://www.conventionalcommits.org/en/v1.0.0/ requirements? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the NPM man page, npm gets its configuration information from 5 separate sources. When npm is launched on a *nix system without the user shell npm skips any configuration in the user's $HOME as well as ignores environment variables that might be set in the user's profile or environment.
This resolves #1889 and @ZuhayrMerchant110's issue as well as mine where the project directory prefixing the appium path.
Change list
Invoke NPM on Mac and Linux systems with Shell (
/bin/sh) to have access to user profile configurations.Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
xin the boxes that applyDetails
Please provide more details about changes if it is necessary. If there are new features you can provide code samples which show the way they
work and possible use cases. Also you can create gists with pasted java code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub