feat: Add ability to use secure WebSocket to listen Logcat messages #2182
+30
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valfirst
requested review from
mykola-mokhnach,
SrinivasanTarget and
saikrishna321
as code owners
| } | ||
| String scheme = useSecureConnection ? "wss" : "ws"; | ||
| SessionId sessionId = ((RemoteWebDriver) this).getSessionId(); | ||
| URI endpointUri = URI.create(String.format("%s://%s:%s/ws/session/%s/appium/device/logcat", scheme, host, |
There was a problem hiding this comment.
cannot we detect this automatically be checking the server url? I assume if the server uses https then the web socket might only be secure as well
There was a problem hiding this comment.
yes, I think, we can determine the scheme if server URL is available, but what will be a reliable way to get it? I can invent something like:
URL serverUrl = ((HttpCommandExecutor)((RemoteWebDriver) this).getCommandExecutor()).getAddressOfRemoteServer()Also having this URL, is it needed to keep methods like:
startLogcatBroadcast(String host)
startLogcatBroadcast(String host, int port)
?
There was a problem hiding this comment.
Sorry, the PR got lost in the stream. @valfirst feel free to ping me in slack if you need a review
we just check if the URLs protocol is https. that is enough. No other changes or overloads would be needed with that
|
Probably here will be a similar issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
Closes #2181.
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
xin the boxes that applyDetails