feat: Add ability to use secure WebSocket to listen Logcat messages #2182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valfirst
requested review from
mykola-mokhnach,
SrinivasanTarget and
saikrishna321
as code owners
src/main/java/io/appium/java_client/android/ListensToLogcatMessages.java
Outdated
Show resolved
Hide resolved
|
Probably here will be a similar issue. |
valfirst
force-pushed
the
add-ability-to-use-secure-websocket-to-listen-logcat-messages
branch
2 times, most recently
from
5d4062a to
3ab6e91
Compare
src/main/java/io/appium/java_client/android/ListensToLogcatMessages.java
Outdated
Show resolved
Hide resolved
mykola-mokhnach
approved these changes
Jul 9, 2024
valfirst
force-pushed
the
add-ability-to-use-secure-websocket-to-listen-logcat-messages
branch
from
3ab6e91 to
78afa2a
Compare
valfirst
deleted the
add-ability-to-use-secure-websocket-to-listen-logcat-messages
branch
|
Hi @valfirst , congrats, the Appium project wants to compensate you for this (and perhaps other) contribution(s) this month! Please reply to this comment mentioning me and sharing your OpenCollective account name, so that we can initiate payment! Or let me know if you decline to receive compensation via OpenCollective. Thank you! |
|
Hi @jlipps, here is a link to my account: https://opencollective.com/valfirst |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
Closes #2181.
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
xin the boxes that applyDetails