feat: Implement HasBiDi interface support in AppiumDriver #2250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykola-mokhnach
requested review from
SrinivasanTarget,
saikrishna321 and
valfirst
as code owners
mykola-mokhnach
commented
Dec 14, 2024
| @@ -171,54 +181,6 @@ public AppiumDriver(URL remoteSessionAddress, String platformName, String automa | |||
| setSessionId(sessionAddress.getId()); | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
these methods were just moved to the end of the class definitions, no changes made to them
valfirst
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
This is the first PR in series where I would like to implement BiDi protocol support with Java client.
The Appium server and drivers only support some parts of the spec, but something is better than nothing (also not everything in the spec makes sense for our context). In time I expect the variety of events and commands to grow bigger.
Types of changes