complete deprecations in store monitoring routes

appknox · Nov 5, 2024 · 01286b2 · 01286b2
1 parent 1573f5e
commit 01286b2
Show file tree

Hide file tree

Showing 12 changed files with 25 additions and 23 deletions.
diff --git a/app/components/app-monitoring/settings/filter-selected-item/index.ts b/app/components/app-monitoring/settings/filter-selected-item/index.ts
@@ -1,7 +1,7 @@
 import Component from '@glimmer/component';
 
 interface AppMonitoringSettingsFilterSelectedItemArgs {
-  extra?: Record<string, unknown>;
+  extra?: Record<string, string>;
 }
 
 export default class AppMonitoringSettingsFilterSelectedItemComponent extends Component<AppMonitoringSettingsFilterSelectedItemArgs> {
@@ -18,7 +18,7 @@ export default class AppMonitoringSettingsFilterSelectedItemComponent extends Co
   }
 
   get iconName() {
-    return this.args.extra?.['iconName'];
+    return this.args.extra?.['iconName'] as string;
   }
 }
 

diff --git a/app/components/app-monitoring/settings/index.hbs b/app/components/app-monitoring/settings/index.hbs
@@ -53,7 +53,9 @@
           showLabel=true
           iconName='filter-list'
         }}
-        @selectedItemComponent='app-monitoring/settings/filter-selected-item'
+        @selectedItemComponent={{component
+          'app-monitoring/settings/filter-selected-item'
+        }}
         {{style width='auto'}}
         class='select-platform-class'
         data-test-select-platform-container

diff --git a/app/components/app-monitoring/table/index.ts b/app/components/app-monitoring/table/index.ts
@@ -58,7 +58,7 @@ export default class AppMonitoringTableComponent extends Component<AppMonitoring
   }
 
   get monitoringData() {
-    return this.appmonitoring.appMonitoringData?.toArray();
+    return this.appmonitoring.appMonitoringData?.slice();
   }
 
   get limit() {

diff --git a/app/components/app-monitoring/table/store-version/index.ts b/app/components/app-monitoring/table/store-version/index.ts
@@ -48,7 +48,7 @@ export default class AppMonitoringTableStoreVersionComponent extends Component<A
 
     // Fetch the latest versions for
     const latestAmAppVersions = await this.store.query('am-app-version', query);
-    const versions = latestAmAppVersions.toArray();
+    const versions = latestAmAppVersions.slice();
 
     this.latestAmAppVersions = versions;
   });

diff --git a/app/components/app-monitoring/version-table/countries/index.ts b/app/components/app-monitoring/version-table/countries/index.ts
@@ -57,7 +57,7 @@ export default class AppMonitoringVersionTableCountriesComponent extends Compone
         amAppVersionId,
       })) as AmAppRecordModelArray;
 
-      const records = amAppRecords.toArray();
+      const records = amAppRecords.slice();
       const countryCodes = [];
 
       for (let idx = 0; idx < records.length; idx++) {

diff --git a/app/components/app-monitoring/version-table/index.ts b/app/components/app-monitoring/version-table/index.ts
@@ -146,7 +146,7 @@ export default class AppMonitoringVersionTableComponent extends Component<AppMon
       })) as AmAppVersionsModelArray;
 
       this.totalStoreVersions = amAppVersions.meta.count;
-      this.storeVersionsToDisplay = amAppVersions.toArray();
+      this.storeVersionsToDisplay = amAppVersions.slice();
     } catch (error) {
       this.notify.error(parseError(error));
     }

diff --git a/app/models/am-app-record.ts b/app/models/am-app-record.ts
@@ -4,12 +4,12 @@ import AmAppSyncModel from './am-app-sync';
 import AmAppStoreInstanceModel from './am-app-store-instance';
 
 export default class AmAppRecordModel extends Model {
-  @belongsTo('am-app-version', { inverse: null })
+  @belongsTo('am-app-version', { async: true, inverse: null })
   declare amAppVersion: AsyncBelongsTo<AmAppVersionModel>;
 
-  @belongsTo('am-app-sync', { inverse: null })
+  @belongsTo('am-app-sync', { async: true, inverse: null })
   declare amAppSync: AsyncBelongsTo<AmAppSyncModel>;
 
-  @belongsTo('am-app-store-instance', { inverse: null })
+  @belongsTo('am-app-store-instance', { async: true, inverse: null })
   declare amAppStoreInstance: AsyncBelongsTo<AmAppStoreInstanceModel>;
 }
diff --git a/app/models/am-app-store-instance.ts b/app/models/am-app-store-instance.ts
@@ -17,6 +17,6 @@ export default class AmAppStoreInstanceModel extends Model {
   @attr('string')
   declare countryCode: string;
 
-  @belongsTo('am-app')
+  @belongsTo('am-app', { async: true, inverse: null })
   declare amApp: AsyncBelongsTo<AmAppModel>;
 }
diff --git a/app/models/am-app-sync.ts b/app/models/am-app-sync.ts
@@ -5,7 +5,7 @@ export default class AmAppSyncModel extends Model {
   @attr('date')
   declare syncedOn: Date;
 
-  @belongsTo('am-app')
+  @belongsTo('am-app', { async: true, inverse: 'lastSync' })
   declare amApp: AsyncBelongsTo<AmAppModel>;
 }
 

diff --git a/app/models/am-app-version.ts b/app/models/am-app-version.ts
@@ -22,13 +22,13 @@ export default class AmAppVersionModel extends Model {
   @attr('string')
   declare appName: string;
 
-  @belongsTo('am-app')
+  @belongsTo('am-app', { async: true, inverse: null })
   declare amApp: AsyncBelongsTo<AmAppModel>;
 
-  @belongsTo('submission')
+  @belongsTo('submission', { async: true, inverse: null })
   declare uploadSubmission: AsyncBelongsTo<SubmissionModel>;
 
-  @belongsTo('file', { inverse: null })
+  @belongsTo('file', { async: true, inverse: null })
   declare latestFile: AsyncBelongsTo<FileModel>;
 }
 

diff --git a/app/models/am-app.ts b/app/models/am-app.ts
@@ -21,25 +21,25 @@ export default class AmAppModel extends Model {
   @attr('boolean')
   declare isActive: boolean;
 
-  @belongsTo('amconfiguration')
+  @belongsTo('amconfiguration', { async: true, inverse: null })
   declare amConfiguration: AsyncBelongsTo<AMConfigurationModel>;
 
-  @belongsTo('project')
+  @belongsTo('project', { async: true, inverse: null })
   declare project: AsyncBelongsTo<ProjectModel>;
 
-  @belongsTo('am-app-sync', { inverse: null })
+  @belongsTo('am-app-sync', { async: true, inverse: 'amApp' })
   declare lastSync: AsyncBelongsTo<AmAppSyncModel>;
 
-  @belongsTo('am-app-version', { inverse: null })
+  @belongsTo('am-app-version', { async: true, inverse: null })
   declare latestAmAppVersion: AsyncBelongsTo<AmAppVersionModel>;
 
-  @belongsTo('am-app-version', { inverse: null })
+  @belongsTo('am-app-version', { async: true, inverse: null })
   declare relevantAmAppVersion: AsyncBelongsTo<AmAppVersionModel>;
 
-  @hasMany('am-app-sync')
+  @hasMany('am-app-sync', { async: true, inverse: 'amApp' })
   declare amAppSyncs: AsyncHasMany<AmAppSyncModel>;
 
-  @hasMany('am-app-version')
+  @hasMany('am-app-version', { async: true, inverse: 'amApp' })
   declare amAppVersions: AsyncHasMany<AmAppVersionModel>;
 
   get isPending() {

diff --git a/app/models/amconfiguration.ts b/app/models/amconfiguration.ts
@@ -5,7 +5,7 @@ export default class AMConfigurationModel extends Model {
   @attr('boolean')
   declare enabled: boolean;
 
-  @belongsTo('organization')
+  @belongsTo('organization', { async: true, inverse: null })
   declare organization: AsyncBelongsTo<OrganizationModel>;
 }