new logic changes support for multiline body

appknox · Sep 6, 2024 · 60cb89e · 60cb89e
1 parent 6be02b0
commit 60cb89e
Show file tree

Hide file tree

Showing 7 changed files with 223 additions and 155 deletions.
diff --git a/app/components/file-details/vulnerability-analysis-details/findings/vulnerable-api/index.hbs b/app/components/file-details/vulnerability-analysis-details/findings/vulnerable-api/index.hbs
@@ -24,24 +24,14 @@
       {{/if}}
     {{/each}}
 
-    {{#if @currentVulnerability.request.body}}
-      {{#unless this.isRequestBodyEmpty}}
-        <AkTypography @color='textSecondary'>
-          {{t 'requestBody'}}:
-        </AkTypography>
-
-        <div local-class='vulnerability-finding-container'>
-          <pre
-            local-class='vulnerability-finding-description {{if
-              @analysis.isOverriddenAsPassed
-              "analysis-overridded-passed"
-            }}'
-          >
-            {{@currentVulnerability.request.body}}
-          </pre>
-        </div>
-      {{/unless}}
-    {{/if}}
+    {{#unless this.isRequestBodyEmpty}}
+      <FileDetails::VulnerabilityAnalysisDetails::Findings::CodeBox
+        @title={{t 'requestBody'}}
+        @copyIcon={{true}}
+        @markedAsPassed={{@analysis.isOverriddenAsPassed}}
+      >{{@currentVulnerability.request.body}}
+      </FileDetails::VulnerabilityAnalysisDetails::Findings::CodeBox>
+    {{/unless}}
 
     {{#unless this.isRequestHeadersEmpty}}
       <FileDetails::VulnerabilityAnalysisDetails::Findings::CodeBox
@@ -63,6 +53,17 @@
       </FileDetails::VulnerabilityAnalysisDetails::Findings::CodeBox>
     {{/unless}}
 
+    {{#unless this.isRequestCookiesEmpty}}
+      <FileDetails::VulnerabilityAnalysisDetails::Findings::CodeBox
+        @title={{t 'cookies'}}
+        @copyIcon={{true}}
+        @markedAsPassed={{@analysis.isOverriddenAsPassed}}
+      >{{#each-in @currentVulnerability.response.cookies as |key value|}}<span
+          >{{key}}: {{value}}</span>
+        {{/each-in}}
+      </FileDetails::VulnerabilityAnalysisDetails::Findings::CodeBox>
+    {{/unless}}
+
     {{#if @currentVulnerability.response.status_code}}
       <FileDetails::VulnerabilityAnalysisDetails::Findings::CodeBox
         @title={{t 'response'}}
@@ -82,6 +83,17 @@
       </FileDetails::VulnerabilityAnalysisDetails::Findings::CodeBox>
     {{/unless}}
 
+    {{#unless this.isResponseCookiesEmpty}}
+      <FileDetails::VulnerabilityAnalysisDetails::Findings::CodeBox
+        @title={{t 'cookies'}}
+        @copyIcon={{true}}
+        @markedAsPassed={{@analysis.isOverriddenAsPassed}}
+      >{{#each-in @currentVulnerability.response.cookies as |key value|}}<span
+          >{{key}}: {{value}}</span>
+        {{/each-in}}
+      </FileDetails::VulnerabilityAnalysisDetails::Findings::CodeBox>
+    {{/unless}}
+
     {{#unless this.isResponseBodyEmpty}}
       <FileDetails::VulnerabilityAnalysisDetails::Findings::CodeBox
         @title={{t 'responseBody'}}

diff --git a/app/components/file-details/vulnerability-analysis-details/findings/vulnerable-api/index.ts b/app/components/file-details/vulnerability-analysis-details/findings/vulnerable-api/index.ts
@@ -73,6 +73,18 @@ export default class FileDetailsVulnerabilityAnalysisDetailsFindingsVulnerableAp
     return body === "''" || body === '';
   }
 
+  get isRequestCookiesEmpty() {
+    const cookies = this.args.currentVulnerability?.request?.cookies;
+
+    return cookies && Object.keys(cookies).length === 0;
+  }
+
+  get isResponseCookiesEmpty() {
+    const cookies = this.args.currentVulnerability?.response?.cookies;
+
+    return cookies && Object.keys(cookies).length === 0;
+  }
+
   get requestParamsKey() {
     const key = this.args.currentVulnerability?.request.params.key;