Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OIDC login workflow #1241

Merged
merged 1 commit into from
Feb 27, 2024
Merged

OIDC login workflow #1241

merged 1 commit into from
Feb 27, 2024

Conversation

Yibaebi
Copy link
Contributor

@Yibaebi Yibaebi commented Jul 25, 2023

No description provided.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 25, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 110be9f
Status: ✅  Deploy successful!
Preview URL: https://eda0d1a4.irenestaging.pages.dev
Branch Preview URL: https://freshdesk-login-updates.irenestaging.pages.dev

View logs

@Yibaebi Yibaebi force-pushed the freshdesk-login-updates branch from a64f268 to cf18009 Compare July 26, 2023 14:23
@Yibaebi Yibaebi force-pushed the freshdesk-login-updates branch from cf18009 to 3348f72 Compare July 31, 2023 21:27
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@future-pirate-king future-pirate-king force-pushed the freshdesk-login-updates branch 2 times, most recently from 78bc087 to f87930c Compare February 9, 2024 13:10
@future-pirate-king future-pirate-king changed the title update password login workflow OIDC login workflow Feb 9, 2024
cosmosgenius
cosmosgenius requested changes Feb 16, 2024
View reviewed changes
app/services/oidc.ts Show resolved Hide resolved
@future-pirate-king future-pirate-king marked this pull request as ready for review February 16, 2024 11:07
@cypress Cypress
Copy link

cypress bot commented Feb 16, 2024 •
edited
Loading

Passing run #71 ↗︎

0 7 0 0 Flakiness 0

Details:

Merge 110be9f into 339bba9...
Project: Irene Commit: 6fe6dff0ca ℹ️
Status: Passed Duration: 02:06 💡
Started: Feb 27, 2024 4:09 AM Ended: Feb 27, 2024 4:12 AM

Review all test suite changes for PR #1241 ↗︎

Yibaebi
Yibaebi commented Feb 22, 2024
View reviewed changes
app/authenticators/irene.js Show resolved Hide resolved
app/authenticators/saml2.js Show resolved Hide resolved
app/services/oidc.ts Show resolved Hide resolved
app/services/oidc.ts Show resolved Hide resolved
app/services/oidc.ts Show resolved Hide resolved
app/templates/oidc/authorize.hbs Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
16 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@future-pirate-king future-pirate-king merged commit 3289ad1 into develop Feb 27, 2024
8 checks passed
@future-pirate-king future-pirate-king deleted the freshdesk-login-updates branch February 27, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@future-pirate-king future-pirate-king future-pirate-king left review comments

@cosmosgenius cosmosgenius cosmosgenius approved these changes

@Praseetha-KR Praseetha-KR Awaiting requested review from Praseetha-KR

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yibaebi @cosmosgenius @future-pirate-king