Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sbom deprecations #1480

Merged
merged 1 commit into from
Oct 25, 2024
Merged

fix sbom deprecations #1480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/components/sbom/app-list/filter-selected-item/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,6 @@ export default class SbomAppListFilterSelectedItemComponent extends Component<Sb
declare module '@glint/environment-ember-loose/registry' {
export default interface Registry {
'Sbom::AppList::FilterSelectedItem': typeof SbomAppListFilterSelectedItemComponent;
'sbom/app-list/filter-selected-item': typeof SbomAppListFilterSelectedItemComponent;
}
}
2 changes: 1 addition & 1 deletion app/components/sbom/app-list/header/index.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
showLabel=true
iconName='filter-list'
}}
@selectedItemComponent='sbom/app-list/filter-selected-item'
@selectedItemComponent={{component 'sbom/app-list/filter-selected-item'}}
{{style width='auto'}}
class='select-platform-class'
data-test-select-platform-container
Expand Down
2 changes: 1 addition & 1 deletion app/components/sbom/app-list/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export default class SbomAppListComponent extends Component<SbomAppListSignature
}

get sbomProjectList() {
return this.sbomProjectQueryResponse?.toArray() || [];
return this.sbomProjectQueryResponse?.slice() || [];
}

get totalSbomProjectCount() {
Expand Down
2 changes: 1 addition & 1 deletion app/components/sbom/app-scan/list/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ export default class SbomAppScanListComponent extends Component<SbomAppScanListS
}

get sbomFileList() {
return this.sbomFileQueryResponse?.toArray() || [];
return this.sbomFileQueryResponse?.slice() || [];
}

get totalSbomScanCount() {
Expand Down
2 changes: 1 addition & 1 deletion app/components/sbom/component-details/vulnerabilities/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export default class SbomComponentDetailsVulnerabilitiesComponent extends Compon
}

get sbomVulnerabilityList() {
return this.componentVulnerabilityQueryResponse?.toArray() || [];
return this.componentVulnerabilityQueryResponse?.slice() || [];
future-pirate-king marked this conversation as resolved.
Show resolved Hide resolved
}

get totalSbomVulnerabilityCount() {
Expand Down
2 changes: 1 addition & 1 deletion app/components/sbom/scan-details/component-list/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export default class SbomScanDetailsComponentListComponent extends Component<Sbo
}

get sbomComponentList() {
return this.componentQueryResponse?.toArray() || [];
return this.componentQueryResponse?.slice() || [];
future-pirate-king marked this conversation as resolved.
Show resolved Hide resolved
}

get totalSbomComponentCount() {
Expand Down
2 changes: 1 addition & 1 deletion app/models/sbom-component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export interface SbomComponentProperty {
}

export default class SbomComponentModel extends Model {
@belongsTo('sbom-file')
@belongsTo('sbom-file', { async: true, inverse: null })
declare sbFile: AsyncBelongsTo<SbomFileModel>;

@attr('string')
Expand Down
2 changes: 1 addition & 1 deletion app/models/sbom-vulnerability-audit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ type ParsedVersion = {
};

export default class SbomVulnerabilityAuditModel extends Model {
@belongsTo('sbom-vulnerability', { async: false })
@belongsTo('sbom-vulnerability', { async: false, inverse: null })
declare sbVulnerability: SbomVulnerabilityModel;

@attr()
Expand Down
Loading