-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bux Fix: Personal Token Submit Refreshes Page #1516
Bux Fix: Personal Token Submit Refreshes Page #1516
Conversation
WalkthroughThe pull request modifies the personal token generation form in the developer settings component. The changes update the form's event handling mechanism, shifting from a button click event to a form submission event. This allows users to generate tokens by pressing Enter or clicking the button. The modifications enhance form interaction while maintaining the existing token generation logic and loading state indicators. Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Deploying irenestaging with Cloudflare Pages
|
Irene Run #564
Run Properties:
|
Project |
Irene
|
Branch Review |
PD-1637-Bug-Fix-Personal-Token-Submit-Refreshes-Page
|
Run status |
Failed #564
|
Run duration | 05m 19s |
Commit |
940a367476 ℹ️: Merge f358f37cfe84a50ab396f9b061d98ea821005a3f into 598e261ffaf2224873ee4da63282...
|
Committer | SmitGala |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
3
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
29
|
View all changes introduced in this branch ↗︎ |
Tests for review
dynamic-scan.spec.ts • 1 failed test
Test | Artifacts | |
---|---|---|
Dynamic Scan > it tests dynamic scan for an ipa file: 58061 |
Test Replay
Screenshots
|
upload-app.spec.ts • 1 failed test
Test | Artifacts | |
---|---|---|
Upload App > It successfully uploads an apk file (via link) |
Test Replay
Screenshots
|
service-account.spec.ts • 1 failed test
Test | Artifacts | |
---|---|---|
Service Account > should create service account with expiry for some projects & delete it |
Test Replay
Screenshots
|
f358f37
to
0c369ed
Compare
Quality Gate passedIssues Measures |
No description provided.