refactor library utility more pythonic #136
Open
+13
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use .get - use f-strings (since we support only 3.8+) - use walrus operator (3.8+)
|
@Reskov Are there any performance or other reasons for performing this change besides style? |
|
This is more about style, rather the performance. For example, in +[] will get one extra dictionary lookup, so as general rule it is better to use get in such case. The same true about getattr, or f-string. But the impact of this is very low, so I am not sure that we will notice this in practice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.getinstead ofinand[]preventing extra dictionary lookupgetattraccess in caseraw_fieldfound