-
Notifications
You must be signed in to change notification settings - Fork 183
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Avoid implicit task dependencies for grpc generated tasks (#2442)
Motivation: The protobuf gradle plugin will generate tasks dynamically, which have implicit relationships on our dynamically generated quality tasks (pmd, spotbugs, checkstyle). Gradle build generates warnings and deoptimizes some flows. ``` Execution optimizations have been disabled for task ':servicetalk-grpc-health:pmdMain' to ensure correctness due to the following reasons: - Gradle detected a problem with the following location: '/Users/scottmitchell/git/servicetalk/servicetalk-grpc-health/src/generated'. Reason: Task ':servicetalk-grpc-health:pmdMain' uses this output of task ':servicetalk-grpc-health:generateTestProto' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.6-rc-3/userguide/validation_problems.html#implicit_dependency for more details about this problem. ```
- Loading branch information
1 parent
d76b87b
commit 07255b0
Showing
4 changed files
with
22 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters