Skip to content

Commit

Permalink
Do not use TLSv1.1 in tests (#1533)
Browse files Browse the repository at this point in the history
Motivation:

TLS 1.0 and 1.1 were disabled in the latest JDK releases because they are
no longer considered secure. As the result of this JDK upgrade,
`SecureTcpTransportObserverErrorsTest.testSslErrors` started to fail when
it uses JDK provider with TLSv1.1.

Modifications:

- Use TLSv1.3 instead of TLSv1.1 for `SecureTcpTransportObserverErrorsTest`;

Result:

Fixes #1530.
  • Loading branch information
idelpivnitskiy committed May 7, 2021
1 parent ecec67e commit 53d5329
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ public SecureTcpTransportObserverErrorsTest(ErrorReason errorReason,
case NOT_MATCHING_PROTOCOLS:
clientSslBuilder.sslProtocols("TLSv1.2");
clientConfig.sslConfig(clientSslBuilder.build());
serverSslBuilder.sslProtocols("TLSv1.1");
serverSslBuilder.sslProtocols("TLSv1.3");
serverConfig.sslConfig(serverSslBuilder.build());
break;
case NOT_MATCHING_CIPHERS:
Expand Down

0 comments on commit 53d5329

Please sign in to comment.