Use Publisher#replay operator #2700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scottmitch
requested review from
daschl,
mgodave,
bryce-anderson,
tkountis and
idelpivnitskiy
|
Depends on and Builds on #2684 (ignore Publisher#replay operator implementation). |
Scottmitch
force-pushed
the
use_replay
branch
from
c68186f to
4db62e4
Compare
Scottmitch
force-pushed
the
use_replay
branch
from
4db62e4 to
4aa48a6
Compare
Scottmitch
force-pushed
the
use_replay
branch
2 times, most recently
from
07d74e5 to
b5636d9
Compare
servicetalk-loadbalancer/src/main/java/io/servicetalk/loadbalancer/RoundRobinLoadBalancer.java
Show resolved
Hide resolved
.../test/java/io/servicetalk/http/netty/RetryingHttpRequesterFilterAutoRetryStrategiesTest.java
Show resolved
Hide resolved
...lk-http-netty/src/test/java/io/servicetalk/http/netty/H2PriorKnowledgeFeatureParityTest.java
Show resolved
Hide resolved
...talk-http-netty/src/main/java/io/servicetalk/http/netty/AbstractStreamingHttpConnection.java
Outdated
Show resolved
Hide resolved
servicetalk-http-netty/src/main/java/io/servicetalk/http/netty/RetryingHttpRequesterFilter.java
Outdated
Show resolved
Hide resolved
servicetalk-http-netty/src/main/java/io/servicetalk/http/netty/RetryingHttpRequesterFilter.java
Outdated
Show resolved
Hide resolved
idelpivnitskiy
approved these changes
Oct 4, 2023
servicetalk-http-netty/src/main/java/io/servicetalk/http/netty/RetryingHttpRequesterFilter.java
Outdated
Show resolved
Hide resolved
Motivation: Publisher#replay was recently added, and there are use cases that can be simplified/improved by using this new operator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Publisher#replay was recently added, and there are use cases
that can be simplified/improved by using this new operator.