Extract inner types from RoundRobinLoadBalancer #2724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The RoundRobinLoadBalancer contains a bunch of code that is doing a good deal more than load balancing, namely it's doing pooling, circuit breaking, and other things. This both makes the implementation hard to read and reason about and makes the inner pieces difficult to reuse for future load balancer implementation. Modifications: - Extract the types into their own files. - Hide a bit of the internal state to start to define abstraction boundaries. Note that this is pretty minimal so far, just accessors etc, so to keep this PR mechanical in nature.
idelpivnitskiy
approved these changes
Oct 6, 2023
servicetalk-loadbalancer/src/main/java/io/servicetalk/loadbalancer/Exceptions.java
Outdated
Show resolved
Hide resolved
servicetalk-loadbalancer/src/main/java/io/servicetalk/loadbalancer/Host.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The RoundRobinLoadBalancer contains a bunch of code that is doing a good deal more than load balancing, namely it's doing pooling, circuit breaking, and other things. This both makes the implementation hard to read and reason about and makes the inner pieces difficult to reuse for future load balancer implementation.
Modifications: