Enhance PMD rules #2753
Merged
Enhance PMD rules #2753
+588
−435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idelpivnitskiy
force-pushed
the
pmd-rules
branch
from
f6bff61 to
6d87ba7
Compare
bryce-anderson
approved these changes
Nov 18, 2023
servicetalk-http-netty/src/test/java/io/servicetalk/http/netty/HttpsProxyTest.java
Outdated
Show resolved
Hide resolved
...talk-http-netty/src/test/java/io/servicetalk/http/netty/RetryingHttpRequesterFilterTest.java
Show resolved
Hide resolved
servicetalk-http-netty/src/test/java/io/servicetalk/http/netty/StreamObserverTest.java
Outdated
Show resolved
Hide resolved
servicetalk-http-netty/src/test/java/io/servicetalk/http/netty/TestServiceStreaming.java
Outdated
Show resolved
Hide resolved
...nal/src/main/java/io/servicetalk/http/router/jersey/internal/BufferPublisherInputStream.java
Show resolved
Hide resolved
daschl
reviewed
Nov 21, 2023
...alk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/NoopAsyncContextProvider.java
Show resolved
Hide resolved
daschl
reviewed
Nov 21, 2023
servicetalk-http-api/src/test/java/io/servicetalk/http/api/AbstractHttpHeadersTest.java
Show resolved
Hide resolved
daschl
reviewed
Nov 21, 2023
servicetalk-http-netty/src/main/java/io/servicetalk/http/netty/H2ToStH1Utils.java
Show resolved
Hide resolved
|
Other than the comments, looks good to me. Admittedly I did not read every exclude rule in detail, but I think if we want to enable more we should do in follow-up PRs since this one is quite big already and naturally touches a lot of files. |
Those that are left excluded were quite noisy and didn't provide much value. I'm happy to exclude more rules and revert changes if anything looks unreasonable. |
daschl
approved these changes
Nov 27, 2023
bryce-anderson
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Currently,
pmd/basic.xmldefines explicit set of rules to validate. With thisstrategy we miss all new rules that PMD adds overtime.
Modifications:
pmd/basic.xmlto include all rules by default but exclude thosethat are not providing much value;
Result:
More coverage during automated code validation that will reduce nit-picking
comments during PR reviews.