ClientEffectiveStrategyTest: Attempt at fixing flakyness #2804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Linking #2245 |
Based on initial analysis the ClientInvokingThreadRecorder's state gets written and read from multiple threads, but not all of it is properly thread-safe. The invokingThreads and errors use thread-safe datastructures, but the offloadPoints do not. Since the offloadPoints are on the critical path for the flaky test failures, let's start by making them thread safe and check if the errors still show up. If they still persist, there might be more coordination needed between the recording and checking threads as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on initial analysis the ClientInvokingThreadRecorder's state gets written and read from multiple threads, but not all of it is properly thread-safe. The invokingThreads and errors use thread-safe datastructures, but the offloadPoints do not.
Since the offloadPoints are on the critical path for the flaky test failures, let's start by making them thread safe and check if the errors still show up.
If they still persist, there might be more coordination needed between the recording and checking threads as well.