Align HttpRequester
/StreamingHttpRequester
with blocking variants
#3201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
BlockingHttpRequester
andBlockingStreamingHttpRequester
implementGracefulAutoCloseable
interface and in result can be used in try-with-resources. For some reason, ourHttpRequester
andStreamingHttpRequester
don't but their client and connection interfaces do.Modifications:
GracefulAutoCloseable
interface fromHttpClient
andHttpConnection
toHttpRequester
.GracefulAutoCloseable
interface fromStreamingHttpClient
andStreamingHttpConnection
toStreamingHttpRequester
.Result:
All requester/client/connection interfaces are consistent across all 4 API variants.
Risk:
Minimal,
japicmp.sh
output:However, use-cases that have a static import of a method with name
close
on a requester implementation won't compile. See changes inH2ClientParentConnectionContext
. Error:I consider that as a minimal risk, and ready to revert this change in future releases if any users find it problematic.