Make ParserSpan noncopyable
#15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change helps communicate the intended usage of `ParserSpan`, though it doesn't strictly prevent creating a copy that represents the same memory. Specifically, the `seeking(...)` methods return copies of the span with different boundaries, to support separate parsing of different subregions of memory, and calling e.g. `seeking(toRelativeOffset: 0)` returns an exact copy of the parser span. With a few changes inside the library to handle these explicit copies, this change is fully source compatible with all the included example parsers, further showing that it matches the intended usage and semantics of the library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change helps communicate the intended usage of
ParserSpan, though it doesn't strictly prevent creating a copy that represents the same memory. Specifically, theseeking(...)methods return copies of the span with different boundaries, to support separate parsing of different subregions of memory, and calling e.g.seeking(toRelativeOffset: 0)returns an exact copy of the parser span.With a few changes inside the library to handle these explicit copies, this change is fully source compatible with all the included example parsers, further showing that it matches the intended usage and semantics of the library.
Resolves #13.
Checklist