Skip to content

Fix error handling for array parsing #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2025
Merged

Conversation

natecook1000
Copy link
Member

Addresses an error introduced when rearranging error handling in array parsers. The validation of count being non-negative was dropped at some point along the way; this change brings that check back and switches the Array(parsing:count:parser:) initializer to throw ThrownParsingError instead of having a generic error type parameter.

Checklist

  • I've added at least one test that validates that my change is working, if appropriate
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

Addresses an error introduced when rearranging error handling
in array parsers. The validation of `count` being non-negative
was dropped at some point along the way; this change brings that
check back and switches the `Array(parsing:count:parser:)`
initializer to throw `ThrownParsingError` instead of having a
generic error type parameter.
@natecook1000 natecook1000 merged commit 49e45ef into main Jul 12, 2025
13 checks passed
@natecook1000 natecook1000 deleted the array-error-case branch July 12, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant