-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples: Add a Hello World example using Hummingbird #3
Conversation
Hummingbird currently fails to build with the Static Linux SDK: |
a6a6244
to
b74261a
Compare
f800da9
to
0c9803a
Compare
0c9803a
to
ef2a3f0
Compare
The Hummingbird fix for building with the Static SDK has been merged but is not yet in a release. |
v2.1.0 was released yesterday. EDIT: we might find this crashes now as apple/swift-async-algorithms#325 is still not in a release of AsyncAlgorithms. |
ef2a3f0
to
81bbf65
Compare
🎉
This simple hello world example seems to work for me (on x86), but maybe more complex examples will break. I see that the issue on the hummingbird repo is on ARM - maybe that's significant? |
https://github.com/apple/swift-async-algorithms/releases/tag/1.0.2 has just been tagged and should have the fix in it. |
Oh awesome! |
The example server did eventually crash after sitting idle for a while. This build was using the previous release of async-algorithms, and seemed to work initially. I'll try it with the new release.
|
Others have verified that AsyncAlgorithms v1.0.2 fixes this issue. |
Motivation
Having simple "getting started" examples is helpful for new users. Some users may be more familiar with Hummingbird instead of Vapor.
Modifications
Adds another example, using Hummingbird, and links it into the documentation.
Result
New users who want to use Hummingbird can start from a tested starting point.
Test Plan
Built and deployed the example locally, and ran the soundness checks.