Make NIST PublicKeys conform to Hashable
#176
Conversation
| @@ -88,6 +88,14 @@ extension P256 { | |||
| let pemDocument = ASN1.PEMDocument(type: "PUBLIC KEY", derBytes: self.derRepresentation) | |||
| return pemDocument.pemString | |||
| } | |||
|
|
|||
| public static func ==(lhs: Self, rhs: Self) -> Bool { | |||
There was a problem hiding this comment.
Equatable, Part of #174 but I was unable to create a diff between just this PR and the source branch of that PR.
| @@ -94,6 +94,14 @@ extension ${CURVE} { | |||
| let pemDocument = ASN1.PEMDocument(type: "PUBLIC KEY", derBytes: self.derRepresentation) | |||
| return pemDocument.pemString | |||
| } | |||
|
|
|||
| public static func ==(lhs: Self, rhs: Self) -> Bool { | |||
There was a problem hiding this comment.
Equatable, Part of #174 but I was unable to create a diff between just this PR and the source branch of that PR.
| @@ -453,6 +453,138 @@ class SignatureTests: XCTestCase { | |||
| let compressedX963Positive = Data(base64Encoded: "A+QHCXtGd5WWSQgp37FBPXMy+nnSwFK79QQD0ZeNMv7L")! | |||
| XCTAssertThrowsError(try P256.Signing.PublicKey(x963Representation: compressedX963Positive)) | |||
| } | |||
|
|
|||
|
|
|||
| func testP256SigningPublicKeyEquatable() throws { | |||
There was a problem hiding this comment.
Equatable, Part of #174 but I was unable to create a diff between just this PR and the source branch of that PR.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Thanks for the input here @Sajjon. I'm going to hide both comments, and report @vivoxfold3's, as the assertion is transparently untrue (this is not your first contribution here, and you and I have spoken several times before. The hide is only to keep this PR on-topic, not because your comment wasn't welcome. |
Make ALL
NISTPublicKeys conform toHashableN.B. Merge open PR #174 first (or if #174 is closed, close this one too), since this PR builds on top of that.
Checklist
If you've made changes to
gybfiles.script/generate_boilerplate_files_with_gyband included updated generated files in a commit of this pull requestMotivation:
This is the
NISTanalogue counterpart of #175, so the motivation put in there applies here as well.This PR is an addition of open PR #174.
Modifications:
P256,P384andP521's Signing and KeyAgreementPublicKeybeHashable, by...NISTECPublicKeyto beHashableand addinghash:intofunction inECDH.swift.gybResult:
ALL NIST PublicKey's now conform to
Hashable