Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code to 2024 SDK release #270

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Lukasa
Copy link
Contributor

@Lukasa Lukasa commented Oct 4, 2024

This patch updates Crypto to the 2024 release version of CryptoKit. As with prior years, there are small tweaks to the API surface that cause this to manifest as a semver major. In this instance, the relevant change is the removal of the long-deprecated setters for the hash function block byte counts.

This is another change that meets the technical definition of a semver major, but is practically extraordinarily unlikely to manifest in an actual problem. Nonetheless, we do have to acknowledge the reality that this can break compiling code (e.g. in cases where users have defined protocols that rely on having a setter available, even though they never call through it).

To that end, this pushes Crypto up to 4.0.

@Lukasa Lukasa added the ⚠️ semver/major Breaks existing public API. label Oct 4, 2024
@Lukasa
Copy link
Contributor Author

Lukasa commented Oct 4, 2024

cc @0xTim @ptoffy @gwynne as major downstream customers who may need to be aware of the pending semver major here.

This patch updates Crypto to the 2024 release version of CryptoKit.
As with prior years, there are small tweaks to the API surface that
cause this to manifest as a semver major. In this instance, the
relevant change is the removal of the long-deprecated setters for the
hash function block byte counts.

This is another change that meets the technical definition of a
semver major, but is practically extraordinarily unlikely to manifest
in an actual problem. Nonetheless, we do have to acknowledge the
reality that this can break compiling code (e.g. in cases where users
have defined protocols that rely on having a setter available, even
though they never call through it).

To that end, this pushes Crypto up to 4.0.
@Lukasa Lukasa force-pushed the cb-update-2024-release branch from e04911e to 0fea5a4 Compare October 4, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️ semver/major Breaks existing public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant