Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide CryptoError Typealias #282

Closed
wants to merge 5 commits into from
Closed

Provide CryptoError Typealias #282

wants to merge 5 commits into from

Conversation

0xTim
Copy link
Contributor

@0xTim 0xTim commented Oct 16, 2024

Provide a typealias for CryptoError to point to CryptoKitError to hide the underlying implementation detail

Checklist

  • I've run tests to see all new and existing tests pass
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

If you've made changes to gyb files

  • I've run .script/generate_boilerplate_files_with_gyb and included updated generated files in a commit of this pull request

Motivation:

Resolves #274

Modifications:

[Describe the modifications you've done.]

Result:

[After your change, what will change.]

Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems kinda large for the typealias: the implementation probably doesn't gain much from changing which name it uses.

@0xTim
Copy link
Contributor Author

0xTim commented Oct 20, 2024

The theory was to make it easier for people reading code coming from platforms where they're unaware of what CryptoKit was. However, I'm easy. Closing in favour of #285

@0xTim 0xTim closed this Oct 20, 2024
@0xTim 0xTim deleted the cryptoerror branch October 20, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename CryptoKit errors
2 participants