-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Intial DocC docs #283
Add Intial DocC docs #283
Conversation
@Lukasa can we get this looked at? Currently the SPI docs are just empty https://swiftpackageindex.com/apple/swift-crypto/3.10.0/documentation/crypto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, let's do it.
There are a couple of issues:
BTW I tested it locally with swift-docc-plugin, it's not published on SPI yet |
Are you building on Linux or macOS? |
macOS 15.1.1 |
Ok the issue was the the |
Ok I suspect that's the actual issue. Same with SPI. Docs build on macOS with a default manifest will use the code for macOS, which is nothing since it just re-exports CryptoKit. I'll get a fix up for both |
Adds some additional documentation. I don't know how far you want me to go with documenting everything so let me know. This should at least get the current APIs rendered on SPI. As an aside I'm not a huge fan of linking out to the CryptoKit docs since not everything is available here, all the code is already documented here and most of the tutorials and articles on developer.apple.com for CryptoKit refer to Apple Platform specific stuff, like interacting with the keychain, that is not applicable here.
Resolves #273
Checklist
If you've made changes to
gyb
files.script/generate_boilerplate_files_with_gyb
and included updated generated files in a commit of this pull requestMotivation:
Currently Swift Crypto has no documentation which is not great
Modifications:
Adds additional DocC scaffolding to take advantage of the DocC comments in Crypto and CryptoExtras. Adds an SPI config file for Swift Package Index
Result:
We will have some documentation