Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Intial DocC docs #283

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Add Intial DocC docs #283

merged 2 commits into from
Dec 12, 2024

Conversation

0xTim
Copy link
Contributor

@0xTim 0xTim commented Oct 16, 2024

Adds some additional documentation. I don't know how far you want me to go with documenting everything so let me know. This should at least get the current APIs rendered on SPI. As an aside I'm not a huge fan of linking out to the CryptoKit docs since not everything is available here, all the code is already documented here and most of the tutorials and articles on developer.apple.com for CryptoKit refer to Apple Platform specific stuff, like interacting with the keychain, that is not applicable here.

Resolves #273

Checklist

  • I've run tests to see all new and existing tests pass
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

If you've made changes to gyb files

  • I've run .script/generate_boilerplate_files_with_gyb and included updated generated files in a commit of this pull request

Motivation:

Currently Swift Crypto has no documentation which is not great

Modifications:

Adds additional DocC scaffolding to take advantage of the DocC comments in Crypto and CryptoExtras. Adds an SPI config file for Swift Package Index

Result:

We will have some documentation

@0xTim 0xTim mentioned this pull request Nov 17, 2024
@0xTim
Copy link
Contributor Author

0xTim commented Dec 12, 2024

@Lukasa can we get this looked at? Currently the SPI docs are just empty https://swiftpackageindex.com/apple/swift-crypto/3.10.0/documentation/crypto

Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, let's do it.

@Lukasa Lukasa added the semver/none No version bump required. label Dec 12, 2024
@Lukasa Lukasa enabled auto-merge (squash) December 12, 2024 16:34
@Lukasa Lukasa merged commit 8650683 into apple:main Dec 12, 2024
34 checks passed
@0xTim 0xTim deleted the add-docc branch December 12, 2024 16:46
@fpseverino
Copy link
Contributor

There are a couple of issues:

  • for Crypto the docs are still empty, except for the new index.md landing page, I don't know why
  • for _CryptoExtras the landing page is missing, I think because index.md starts with ``CryptoExtras`` and not ``_CryptoExtras`` (Rename _CryptoExtras to CryptoExtras #281 might fix this)

BTW I tested it locally with swift-docc-plugin, it's not published on SPI yet

@0xTim
Copy link
Contributor Author

0xTim commented Dec 12, 2024

Are you building on Linux or macOS?

@fpseverino
Copy link
Contributor

macOS 15.1.1

@fpseverino
Copy link
Contributor

Ok the issue was the the development flag in Package.swift was set to false

@0xTim
Copy link
Contributor Author

0xTim commented Dec 12, 2024

Ok I suspect that's the actual issue. Same with SPI. Docs build on macOS with a default manifest will use the code for macOS, which is nothing since it just re-exports CryptoKit. I'll get a fix up for both

@0xTim
Copy link
Contributor Author

0xTim commented Dec 12, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide some docs
3 participants