Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DocC generation #311

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Fix DocC generation #311

merged 2 commits into from
Dec 13, 2024

Conversation

0xTim
Copy link
Contributor

@0xTim 0xTim commented Dec 12, 2024

Fix DocC generation. Force Linux build on SPI to get it to render the Crypto docs

Checklist

  • I've run tests to see all new and existing tests pass
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

If you've made changes to gyb files

  • I've run .script/generate_boilerplate_files_with_gyb and included updated generated files in a commit of this pull request

Motivation:

Currently the Crypto docs are empty on SPI because they're built on macOS where there are no symbols. CryptoExtras index page also doesn't work because of a name mismatch

Modifications:

Force Linux build on SPI, fix name for extras documentation

Result:

Working Docs

@0xTim
Copy link
Contributor Author

0xTim commented Dec 12, 2024

@Lukasa another small one for you, verified locally

@Lukasa Lukasa added the semver/none No version bump required. label Dec 13, 2024
Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks!

@Lukasa Lukasa enabled auto-merge (squash) December 13, 2024 13:02
@Lukasa Lukasa disabled auto-merge December 13, 2024 13:02
@Lukasa Lukasa enabled auto-merge (squash) December 13, 2024 13:02
@Lukasa Lukasa merged commit 600eda3 into apple:main Dec 13, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants