Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added GIT_CLONE_JOBS ARG to Dockerfile #34

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

ashley-b
Copy link
Contributor

This value was hardcoded and was too high for some systems.

I would get the following error

Cloning into '/root/esp/esp-matter/connectedhomeip/connectedhomeip/third_party/pigweed/repo'...
Cloning into '/root/esp/esp-matter/connectedhomeip/connectedhomeip/third_party/infineon/psoc6/psoc6_sdk/libs/btstack'...
Cloning into '/root/esp/esp-matter/connectedhomeip/connectedhomeip/third_party/ti_simplelink_sdk/repo_cc32xx'...
error: RPC failed; curl 92 HTTP/2 stream 0 was not closed cleanly: CANCEL (err 8)
error: 7349 bytes of body are still expected
fetch-pack: unexpected disconnect while reading sideband packet
fatal: early EOF
fatal: fetch-pack: invalid index-pack output
fatal: clone of 'https://github.com/TexasInstruments/cc32xx_open_sdk.git' into submodule path '/root/esp/esp-matter/connectedhomeip/connectedhomeip/third_party/ti_simplelink_sdk/repo_cc32xx' failed
Failed to clone 'third_party/ti_simplelink_sdk/repo_cc32xx'. Retry scheduled
Cloning into '/root/esp/esp-matter/connectedhomeip/connectedhomeip/third_party/infineon/psoc6/psoc6_sdk/libs/wifi-host-driver'...
Cloning into '/root/esp/esp-matter/connectedhomeip/connectedhomeip/third_party/infineon/psoc6/psoc6_sdk/libs/mtb-pdl-cat1'...
Cloning into '/root/esp/esp-matter/connectedhomeip/connectedhomeip/third_party/boringssl/repo/src'...
error: RPC failed; curl 92 HTTP/2 stream 0 was not closed cleanly: CANCEL (err 8)
error: 7443 bytes of body are still expected
fetch-pack: unexpected disconnect while reading sideband packet
fatal: early EOF
fatal: fetch-pack: invalid index-pack output

The image builds correctly when I lower the job count to 2

docker build . --tag swift-matter-examples-builder --build-arg GIT_CLONE_JOBS=2

This value was hardcoded and was too much for some systems.
@rauhul
Copy link
Collaborator

rauhul commented Dec 15, 2024

Is there a way we can do this based on like 2x core count instead of another hard coded value?

@ashley-b
Copy link
Contributor Author

Is there a way we can do this based on like 2x core count instead of another hard coded value?

I dont think this has anything to do with the number of cores. I think it's overloading the network connection at some point.
I've tested this with 4 jobs, and that also works.
The original 24 seamed a bit excessive

@rauhul rauhul merged commit 4dd1df4 into apple:main Jan 3, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants