byte-buffer: use malloc_good_size on Darwin to allocate memory
#3066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: With this change, on Darwin, ByteBuffer will use less memory, and memory allocations will be aligned with pages better, hopefully improving memory efficiency. Modifications: - Introduces a new internal helper method to `_Storage` that returns the optimal storage size - Uses that to malloc capacity.
Lukasa
reviewed
Jan 17, 2025
|
|
||
| @testable import NIOCore | ||
|
|
||
| #if canImport(Darwin) |
There was a problem hiding this comment.
Let's make these tests cross-platform by redefining the logic here. We can just have an abstraction function that is essentially equivalent to mallocSize, but allows us to validate that that's what we're actually using.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
With this change, on Darwin, ByteBuffer will use less memory, and memory allocations will be aligned with pages better, hopefully improving memory efficiency.
This is part 1 of #2770. The next step is to figure out better allocation strategy for Libc, Musl, etc.
Modifications:
_Storagethat returns the optimal storage size