Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always @preconcurrency import Glibc/Musl/Android/Bionic/WASILibc #3153

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

weissi
Copy link
Member

@weissi weissi commented Mar 21, 2025

Motivation:

The non-Darwin libcs don't have the correct concurrency annotations. But due to these Swift bugs, it's important that the first importer uses @preconcurrency:

Modifications:

Much like the Foundation (& corelibs) PRs such as swiftlang/swift-foundation#1175 , use @preconcurrency import for the non-Darwin libcs.

Result:

Fewer bad warnings/errors in user code.

@weissi weissi requested a review from Lukasa March 21, 2025 13:01
@weissi weissi added the 🔨 semver/patch No public API change. label Mar 21, 2025
@Lukasa Lukasa merged commit 40ee44c into apple:main Mar 21, 2025
39 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants