-
Notifications
You must be signed in to change notification settings - Fork 148
[Parsing] Allow OAS versions 3.1.2 and 3.2.0 #840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @mattpolzin 🙏
|
I just removed the two issues from the description, I'd like to keep the open to track adding fuller support for new features in those versions. But this PR at least unblocks parsing those versions, which is more urgent. |
|
Can you rerun the formatter please? |
Done. Happy to squash into previous commit if you'd like. |
|
No need, the merge will squash it |
8e556f1 to
580d98f
Compare
|
Fixed the test failure I somehow missed locally. [EDIT] ... and fixed the fixed commits because my editor keeps dropping a newline from an unrelated test's expected output. |
580d98f to
94b0efa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @mattpolzin 🙏
Motivation
Modifications
The OpenAPIKit dependency has been bumped to 3.9.0+ to use the new version mapping feature.
The generator has been instructed to accept OAS documents of versions 3.1.2 and 3.2.0 in addition to the existing supported versions.
In order to parse OAS 3.2.0 without any of the features it adds, OpenAPIKit has been instructed to parse OAS 3.2.0 as if it were OAS 3.1.2.
Result
OpenAPI Documents versioned 3.1.2 and 3.2.0 will successfully load into the generator.
Test Plan
The test suite has been updated.