Skip to content

Conversation

@mattpolzin
Copy link
Contributor

@mattpolzin mattpolzin commented Oct 22, 2025

Motivation

Modifications

The OpenAPIKit dependency has been bumped to 3.9.0+ to use the new version mapping feature.

The generator has been instructed to accept OAS documents of versions 3.1.2 and 3.2.0 in addition to the existing supported versions.

In order to parse OAS 3.2.0 without any of the features it adds, OpenAPIKit has been instructed to parse OAS 3.2.0 as if it were OAS 3.1.2.

Result

OpenAPI Documents versioned 3.1.2 and 3.2.0 will successfully load into the generator.

Test Plan

The test suite has been updated.

Copy link
Contributor

@czechboy0 czechboy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mattpolzin 🙏

@czechboy0
Copy link
Contributor

I just removed the two issues from the description, I'd like to keep the open to track adding fuller support for new features in those versions. But this PR at least unblocks parsing those versions, which is more urgent.

@czechboy0 czechboy0 added the semver/none No version bump required. label Oct 22, 2025
@czechboy0
Copy link
Contributor

Can you rerun the formatter please?

@mattpolzin
Copy link
Contributor Author

Can you rerun the formatter please?

Done. Happy to squash into previous commit if you'd like.

@czechboy0
Copy link
Contributor

No need, the merge will squash it

@mattpolzin
Copy link
Contributor Author

mattpolzin commented Oct 22, 2025

Fixed the test failure I somehow missed locally.

[EDIT] ... and fixed the fixed commits because my editor keeps dropping a newline from an unrelated test's expected output.

Copy link
Contributor

@czechboy0 czechboy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mattpolzin 🙏

@czechboy0 czechboy0 enabled auto-merge (squash) October 23, 2025 15:04
@czechboy0 czechboy0 merged commit c4f3f1e into apple:main Oct 23, 2025
52 checks passed
@mattpolzin mattpolzin deleted the support-oas-3_2_0 branch October 23, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver/none No version bump required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants