Add useDeterministicOrdering opt-in option to JSON + Binary encoding
#1487
Conversation
* Add `useDeterministicOrdering` to `JSONEncodingOptions` Adds an option to ensure that JSON serialization is deterministic when serializing Protobuf `map` fields. This should be the only type that needs to be sorted, since individual fields are serialized in order by the generated code that invokes `try visitor.visit(...)` for each field. Fixes apple#1477
…pple#1480) * Add `BinaryEncodingOptions` & option for deterministic ordering Implements the same setting added for JSON in apple#1478 for binary serialization. Related to apple#1477.
|
I don't understand the test failure - looks like |
@tbkka wrote the test case collector we used back when SwiftPM didn't have native support to do the work for Linux and can hopefully provide some info. My guess is this line doesn't deal with the |
Ah yea that makes sense. I'll remove |
|
#1488 fixes the problem with having |
|
Thank you for doing the work to pull it to 1.x! |
🙌🏽 do you know when a new release is expected for 1.x? |
|
@tbkka make sense to cut a release? Change since last release:
|
|
I think it's reasonable. |
|
Thank you! |
## Summary Implements support for Connect unary GET requests per https://connectrpc.com/docs/protocol#unary-get-request. By default, this behavior is disabled and can be enabled through an option on `ProtocolClientConfig` (as demonstrated in the Eliza app). Behavior is exercised in a new conformance test, but I do intend to add more unit tests for this after #208. ## Linked issues - Requires apple/swift-protobuf#1487 - Related to apple/swift-protobuf#1478 - Related to apple/swift-protobuf#1480 - Resolves #196
Cherry-picks #1478 and #1480 from
mainonto the 1.x branch. Includes various fixes because these were not clean cherry picks.