Add kustomize files for 0.8.0 release #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leochr
reviewed
Dec 1, 2021
| fieldRef: | ||
| fieldPath: metadata.namespace | ||
| - name: WATCH_NAMESPACE | ||
| value: default |
There was a problem hiding this comment.
Value for WATCH_NAMESPACE can also be specified like OPERATOR_NAMESPACE. In that case the example for watching own namespace can be simplified I think.
fyi to avoid merge conflicts, Melissa has the change to update kustomize/daily/runtime-component-operator.yaml in her PR
Also update the kustomize CRDs to pickup the most recent changes
|
@leochr I've addressed the comments about the watch-own-namespace scenario |
leochr
reviewed
Dec 2, 2021
| @@ -11,3 +11,4 @@ spec: | |||
| env: | |||
| - name: WATCH_NAMESPACE | |||
| value: rco-watched-ns2 | |||
| valueFrom: | |||
There was a problem hiding this comment.
Since this example builds upon overlay, which already removes the valueFrom field, it doesn't need to be specified here again.
As the relevant field is already removed in the parent overlay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update the kustomize CRDs to pickup the most
recent changes
As per the request in issue #177