Virtual_PATH, Added trailing '/' to proxy_pass #1

jswann · 2015-03-26T17:50:34Z

For me to successfully get Virtual_Path's to work, I had to add a trailing slash (/) to the proxy_pass url. Otherwise the proxy would append the path when proxying requests.

* Require `dict` and `sha1` function support in docker-gen

Currently uses the same htpasswd for all services behind a hostname, but it could be desirable to allow different htpasswd for different paths

Multiple paths

…ule was required to redirect to root /

md5 · 2015-03-26T17:59:39Z

Does this work with subpaths of VIRTUAL_PATH? For example, if I put VIRTUAL_PATH=/admin and then request /admin/foo, will the backend see /foo or /?

Assuming that subpaths work correctly, I'm still not sure this is the right default behavior, since I could see this being a matter of user preference. Do you mind bringing up the issue over at nginx-proxy#47 where there can be more visibility? Only you and I are likely to ever see this PR.

md5 · 2015-03-26T18:01:19Z

BTW, this branch is being occasionally rebased against the master branch of jwilder/nginx-proxy, so I may need to pull in your commit in a manual merge (or you could rebase in the event that I rebase).

jswann · 2015-03-26T18:05:51Z

i didn't try it against subpaths of VIRTUAL_PATH, i only needed to route
/admin to /. I'll test it out before I bring up the issue on nginx-proxy#47.

I placed the PR against your branch because I wasn't sure how to generate
one against jwilder/nginx-proxy as a PR.

On Thu, Mar 26, 2015 at 2:01 PM, Mike Dillon [email protected]
wrote:

BTW, this branch is being occasionally rebased against the master branch
of jwilder/nginx-proxy, so I may need to pull in your commit in a manual
merge (or you could rebase in the event that I rebase).

—
Reply to this email directly or view it on GitHub
#1 (comment).

md5 · 2015-03-26T18:10:03Z

Placing a PR against my branch is appropriate. I just wanted to give you a heads-up since I saw that your PR contains commits from the upstream master (which makes me think I need to rebase).

jswann · 2015-03-26T19:59:16Z

Just verified that it'll work for request paths like /admin/foo -- which
will proxy to the backend server on /.

I'll update nginx-proxy#47 with the information.

Thanks.

On Thu, Mar 26, 2015 at 2:10 PM, Mike Dillon [email protected]
wrote:

Placing a PR against my branch is appropriate. I just wanted to give you a
heads-up since I saw that your PR contains commits from the upstream
master (which makes me think I need to rebase).

—
Reply to this email directly or view it on GitHub
#1 (comment).

md5 · 2015-03-26T20:10:25Z

I'm guessing that's not the behavior most people would want. I can imagine two behaviors that I would expect users to want:

Pass through the request URI unchanged
Pass through the request URI with the VIRTUAL_PATH prefix stripped

I don't think that rewriting all requests from VIRTUAL_PATH to / will be a common configuration.

The other thing I wonder about is whether this has any effect on query strings.

jswann · 2015-03-26T20:16:36Z

From my research, which lead me to finding the missing slash, it appears
the only way to achieve the functionality that you're talking about is to
use rewrite rules as well. They'll keep query strings, etc. I was able to
get that working but decided against it after seeing it wasn't really a
best practice in nginx.

But, reading over the comments in the original Issue, I felt that most just
wanted to use a virtual host at times when they weren't able to have the
DNS configured with *.hostname. That's what i'm dealing with in my
organization, and just need to use a servername/context_root as a way to
run multiple services on port 80 on the same docker host.

On Thu, Mar 26, 2015 at 4:10 PM, Mike Dillon [email protected]
wrote:

I'm guessing that's not the behavior most people would want. I see two
behaviors that I would expect users to want:

Pass through the request URI unchanged

Pass through the request URI with the VIRTUAL_PATH prefix stripped

I don't think that rewriting all requests from VIRTUAL_PATH to / will be
a common configuration.

The other thing I wonder about is whether this has any effect on query
strings.

—
Reply to this email directly or view it on GitHub
#1 (comment).

jswann · 2015-03-26T20:19:07Z

also - just to clarify.

If i set VIRTUAL_PATH=/admin:
/admin will proxy to my service on /
/admin/users will proxy to my service on /users

if I set VIRTUAL_PATH=/admin/v1
/admin/v1 will proxy to my service on /
/admin/v1/users will proxy to my service on /users

On Thu, Mar 26, 2015 at 4:16 PM, Josh Swann [email protected] wrote:

From my research, which lead me to finding the missing slash, it appears
the only way to achieve the functionality that you're talking about is to
use rewrite rules as well. They'll keep query strings, etc. I was able to
get that working but decided against it after seeing it wasn't really a
best practice in nginx.

But, reading over the comments in the original Issue, I felt that most
just wanted to use a virtual host at times when they weren't able to have
the DNS configured with *.hostname. That's what i'm dealing with in my
organization, and just need to use a servername/context_root as a way to
run multiple services on port 80 on the same docker host.

On Thu, Mar 26, 2015 at 4:10 PM, Mike Dillon [email protected]
wrote:

I'm guessing that's not the behavior most people would want. I see two
behaviors that I would expect users to want:

Pass through the request URI unchanged

Pass through the request URI with the VIRTUAL_PATH prefix stripped

I don't think that rewriting all requests from VIRTUAL_PATH to / will be
a common configuration.

The other thing I wonder about is whether this has any effect on query
strings.

—
Reply to this email directly or view it on GitHub
#1 (comment).

md5 · 2015-03-26T20:48:09Z

Cool. So that sounds like what I described in the second option. 👍

I'm still not sure what other users would expect the default behavior to be for VIRTUAL_PATH.

WillBeebe · 2015-06-29T22:21:13Z

I would really like to use this feature! anything I can do to help get it merged?

jswann · 2015-06-29T23:35:05Z

Not sure. I've just been using the branch in my repo. I think @md5 has been waiting on the jwilder project before rebasing and merging all changes in

WillBeebe · 2015-06-30T00:31:58Z

Thanks for the update @jswann !

md5 · 2015-07-01T15:29:25Z

@WillBeebe Are you specifically looking for this trailing slash fix (which I'm still not convinced is a good idea as default behavior), or are you talking about getting a new PR for the multiple-paths branch?

In terms of further discussion, I'd like to see that over at nginx-proxy/docker-gen#47 (though I did just comment here too: nginx-proxy#190 (comment))

WillBeebe · 2015-07-07T21:29:34Z

Hi @md5 . I was mostly looking for VIRTUAL_PATH support. Here is a modified nginx.tmpl that I used to do this. Most notably I had to add $host to this line:

https://gist.github.com/WillBeebe/0186bae3ac20f6354819#file-gistfile1-txt-L160

WillBeebe · 2015-07-07T21:32:50Z

My goal is to have an nginx container auto-detect and route to separate rails containers. Here's my docker-compose.yml. Running docker-compose up on this gets me basically what I want. I can add multiple rails containers and nginx will round-robin to those.

https://gist.github.com/WillBeebe/9143ffe79c5dc3882662

Adjust entrypoint to always warn on missing socket

pascalandy · 2016-04-14T02:49:44Z

@WillBeebe, Can you confirm that your modified nginx.tmpl is stable? Issues since 9 months?

Thanks in advance!!
Pascal

jagandecapri · 2016-08-02T14:09:51Z

Hei guys,

I am looking to do something like this.

Nginx proxy -> multiple apps as the following:

Hosted on the same server on different ports
location in Nginx is based on subdirectories

My Nginx config will look something like this.

...
upstream app1{

}
...
location /jenkins {
 ...
 proxy_pass http://app1
 ...
}

I am not really sure whether the fix in this PR is for this use case. If yes, that will be great. Let me know if this is a separate issue that needs to be addressed on its own.

Thanks!!!

md5 · 2016-08-07T16:58:27Z

@jagandecapri The main discussion around supporting your use case is over at nginx-proxy#47. The most recent PR I created to support multiple paths is at nginx-proxy#254, although it is not in a state to be merged. There is also related discussion in nginx-proxy#54 and nginx-proxy#190.

My feeling is still that a custom nginx-proxy binary will be needed to do this properly. The supporting work of making docker-gen stalled a long time ago, but that discussion is at nginx-proxy/docker-gen#131

md5 and others added 5 commits February 25, 2015 22:56

Support paths with VIRTUAL_PATH

23b40ff

* Require `dict` and `sha1` function support in docker-gen

Remove unused $index variable

0c94dc4

Add htpasswd support to pathCount>1 case

6f66d0b

Currently uses the same htpasswd for all services behind a hostname, but it could be desirable to allow different htpasswd for different paths

Merge pull request #1 from md5/multiple-paths

e4141a1

Multiple paths

Added trailing / for Virtual_path's proxy_pass, otherwise a rewrite r…

0c0780e

…ule was required to redirect to root /

md5 force-pushed the multiple-paths branch from 6f66d0b to b3729bd Compare May 4, 2015 04:02

md5 pushed a commit that referenced this pull request Sep 14, 2015

Merge pull request #1 from appropriate/safeguard

d21c694

Adjust entrypoint to always warn on missing socket

md5 force-pushed the multiple-paths branch 4 times, most recently from 6b2e0cf to f2ec4b8 Compare October 9, 2015 03:40

md5 force-pushed the multiple-paths branch 4 times, most recently from f7d9156 to edfedca Compare October 20, 2015 03:34

SatejG mentioned this pull request Jun 15, 2017

Support proxying multiple paths to different backends nginx-proxy/nginx-proxy#254

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Virtual_PATH, Added trailing '/' to proxy_pass #1

Virtual_PATH, Added trailing '/' to proxy_pass #1

jswann commented Mar 26, 2015

md5 commented Mar 26, 2015

md5 commented Mar 26, 2015

jswann commented Mar 26, 2015

md5 commented Mar 26, 2015

jswann commented Mar 26, 2015

md5 commented Mar 26, 2015

jswann commented Mar 26, 2015

jswann commented Mar 26, 2015

md5 commented Mar 26, 2015

WillBeebe commented Jun 29, 2015

jswann commented Jun 29, 2015

WillBeebe commented Jun 30, 2015

md5 commented Jul 1, 2015

WillBeebe commented Jul 7, 2015

WillBeebe commented Jul 7, 2015

pascalandy commented Apr 14, 2016

jagandecapri commented Aug 2, 2016

md5 commented Aug 7, 2016

Virtual_PATH, Added trailing '/' to proxy_pass #1

Are you sure you want to change the base?

Virtual_PATH, Added trailing '/' to proxy_pass #1

Conversation

jswann commented Mar 26, 2015

md5 commented Mar 26, 2015

md5 commented Mar 26, 2015

jswann commented Mar 26, 2015

md5 commented Mar 26, 2015

jswann commented Mar 26, 2015

md5 commented Mar 26, 2015

jswann commented Mar 26, 2015

jswann commented Mar 26, 2015

md5 commented Mar 26, 2015

WillBeebe commented Jun 29, 2015

jswann commented Jun 29, 2015

WillBeebe commented Jun 30, 2015

md5 commented Jul 1, 2015

WillBeebe commented Jul 7, 2015

WillBeebe commented Jul 7, 2015

pascalandy commented Apr 14, 2016

jagandecapri commented Aug 2, 2016

md5 commented Aug 7, 2016