Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump com.approvaltests:approvaltests from 24.13.0 to 24.14.0 #143

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 13, 2025

Bumps com.approvaltests:approvaltests from 24.13.0 to 24.14.0.

Release notes

Sourced from com.approvaltests:approvaltests's releases.

DateScrubber & Approve-All Script

Support more date formats in DateScrubber, see Documentation

Approval-All Script

All failed approvals are now logged in .approval_tests_temp/.failed_comparison.log. There will be also a script generated that will approve all failed tests.

Script assumes it is being run from the .approval_tests_temp directory.

on Unix

cd .approval_tests_temp
./approve_all.sh

on Windows

cd .approval_tests_temp
./approve_all.bat
Commits
  • 8f673b3 @ r remove duplication. Lazy download the approve-all script
  • e21060c @ F add approval-all script to temp directory
  • bc2c99b . d updated markdown snippets
  • 955d5ff - F added even more dates that ChatGPT gave us examples for
  • ccf3c9d - F support for Date format reported by helgewessels, Jan 2025
  • f7c5699 - F Created approve_all.sh
  • 0ecf28d - F Created approve_all.bat
  • 6b446dd a reformat code
  • cb76ba6 - F Added FailedFileLog
  • 8bfb04c v 24.13.0
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Summary by Sourcery

Build:

  • Bump com.approvaltests:approvaltests dependency to 24.14.0.

Bumps [com.approvaltests:approvaltests](https://github.com/approvals/ApprovalTests.Java) from 24.13.0 to 24.14.0.
- [Release notes](https://github.com/approvals/ApprovalTests.Java/releases)
- [Commits](approvals/ApprovalTests.Java@24.13.0...24.14.0)

---
updated-dependencies:
- dependency-name: com.approvaltests:approvaltests
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Jan 13, 2025
Copy link

sourcery-ai bot commented Jan 13, 2025

Reviewer's Guide by Sourcery

This pull request updates the version of com.approvaltests:approvaltests from 24.13.0 to 24.14.0. This change introduces a new feature for logging failed approvals and generating a script to approve all failed tests. Additionally, it enhances the DateScrubber to support more date formats.

Sequence diagram for the new approval test workflow

sequenceDiagram
    participant Test as Test Runner
    participant AT as ApprovalTests
    participant FS as File System

    Test->>AT: Run test with approval
    alt Test fails
        AT->>FS: Log failed test to .failed_comparison.log
        AT->>FS: Generate approve_all script
        Note over FS: Scripts created in .approval_tests_temp/
    end
Loading

Class diagram for DateScrubber enhancement

classDiagram
    class DateScrubber {
        +scrub(text: String): String
    }
    note for DateScrubber "Enhanced with more date format support"
Loading

Flow diagram for the approval process

flowchart TD
    A[Run Tests] --> B{Tests Pass?}
    B -->|Yes| C[Done]
    B -->|No| D[Log Failed Tests]
    D --> E[Generate Approval Scripts]
    E --> F[approve_all.bat/sh]
    F --> G[Approve All Failed Tests]
    G --> C
Loading

File-Level Changes

Change Details Files
Update the dependency version
  • Change the version of com.approvaltests:approvaltests from 24.13.0 to 24.14.0 in the dependencies section
app/build.gradle

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. Here's why:

  • It seems to have been created by a bot (hey, dependabot[bot]!). We assume it knows what it's doing!
  • We don't review packaging changes - Let us know if you'd like us to change this.

@isidore isidore merged commit 32f0d28 into main Jan 13, 2025
4 checks passed
@dependabot dependabot bot deleted the dependabot/gradle/com.approvaltests-approvaltests-24.14.0 branch January 13, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant