-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make package PEP 561 compliant by including py.typed file #170
base: main
Are you sure you want to change the base?
Conversation
🧙 Sourcery has finished reviewing your pull request! Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
49edbf8
to
e9e203a
Compare
@isidore any updates on this? This should be a very small, unproblematic change. Let me know what you think. |
e1303ae
to
91b60f5
Compare
This is resolved by #179 . |
Good to know! Is there any particular reason why this PR was entirely stale for 3 months, just to be replaced by a slightly different PR doing almost the exact same without previous notice? I'm happy for any positive change here, just wanted to understand the processes a bit better. |
I can't speak for the rest of the crew, but for me - I didn't notice yours until mine was almost done, whoops. |
@jonded94 we haven't been paying enough attention to PRs, sorry about that. |
Description
Using this package in a codebase with
mypy
unfortunately leads to errors like these:This is because this package is not properly PEP 561 compliant.
The solution
Adding a
py.typed
file since this package already large has type hints, it just wasn't marked as being typed.